Skip to content

[release-4.11] OCPBUGS-455: vsphere: fix default disk type when not speficied #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 9, 2022
Merged

[release-4.11] OCPBUGS-455: vsphere: fix default disk type when not speficied #6256

openshift-merge-robot merged 1 commit into from
Sep 9, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 23, 2022

This is an automated cherry-pick of #6233

/assign r4f4

@r4f4
Bug 2098072: vsphere: fix default disk type when not speficied
6c85108 
During the terraform decoupling work [1], a fix for the default value
for the disk provisioning type [2] ended up being lost.

This commit bring those changes back, fixing a regression where the
default disk type would be set to "thick" instead of the default storage
policy of vsphere.

[1] openshift@9c77d6a
[2] openshift@f3c9bfa
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 23, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2098072 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 401 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] Bug 2098072: vsphere: fix default disk type when not speficied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from barbacbd and r4f4 August 23, 2022 14:07
@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022 •
edited by openshift-ci bot
Loading

/retitle [release-4.11] OCPBUGS-455: vsphere: fix default disk type when not speficied

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2098072: vsphere: fix default disk type when not speficied [release-4.11] OCPBUGS-455: vsphere: fix default disk type when not speficied Aug 23, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 23, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue OCPBUGS-455](https://issues.redhat.com//browse/OCPBUGS-455), which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)
  • dependent bug Jira Issue OCPBUGS-454 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-454 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents
Details

In response to this:

This is an automated cherry-pick of #6233

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022 •
edited
Loading

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] OCPBUGS-455: vsphere: fix default disk type when not speficied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/assign @patrickdillon

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/test verify-vendor
/test yaml-lint
/test unit
/test verify-codegen
/test tf-lint
/test tf-fmt
/test shellcheck
/test gofmt
/test golint
/test govet
/test images

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/test okd-verify-codegen
/test okd-images

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/test govet
/test aro-unit

@r4f4
Copy link
Contributor

r4f4 commented Aug 23, 2022

/test unit
/test okd-unit
/test aro-unit
/test yaml-lint

barbacbd
barbacbd reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Sep 8, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 8, 2022
@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 9, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 9, 2022
@r4f4
Copy link
Contributor

r4f4 commented Sep 9, 2022

/approve

2 similar comments
@sadasu
Copy link
Contributor

sadasu commented Sep 9, 2022

/approve

@patrickdillon
Copy link
Contributor

patrickdillon commented Sep 9, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, r4f4, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@r4f4
Copy link
Contributor

r4f4 commented Sep 9, 2022

/skip

@r4f4
Copy link
Contributor

r4f4 commented Sep 9, 2022

/test aro-unit

@r4f4
Copy link
Contributor

r4f4 commented Sep 9, 2022

/test images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit dc42d76 into openshift:release-4.11 Sep 9, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-455 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6233

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@barbacbd barbacbd barbacbd left review comments

@r4f4 r4f4 r4f4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@r4f4 r4f4

@patrickdillon patrickdillon

@barbacbd barbacbd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @r4f4 @openshift-ci-robot @patrickdillon @jianlinliu @sadasu @barbacbd @openshift-merge-robot