Skip to content

[release-4.11] OCPBUGS-433: nutanix: allow creating manifests without Prism Central connection #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Aug 30, 2022
Merged

[release-4.11] OCPBUGS-433: nutanix: allow creating manifests without Prism Central connection #6251

openshift-merge-robot merged 2 commits into from
Aug 30, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 22, 2022

This is an automated cherry-pick of #6149

/assign vrutkovs

Vadim Rutkovsky added 2 commits August 22, 2022 20:27
nutanix: allow creating manifests without Prism Central connection
0763d34 
In Assisted Installer we create manifests and generate Ignition in the cloud and pass ignition files to the agents. For platform integration we can't request credentials from users, instead we fill these in with fake credentials and let them change these later.

This commit moves validations to ValidateForProvisioning, so that `openshift-install create manifests` phase would pass with fake credentials
nutanix: allow specifying an optional name for PrismElement
f60ac74 
In Assisted Installer we can't contact Prism Central to resolve
Prism Element name via API. Instead we allow setting it to dummy value
and let users update Infrastructure object later.

This field is optional and would use API call if not set
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 22, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2109538 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 401 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] Bug 2109538: nutanix: allow creating manifests without Prism Central connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from barbacbd and sadasu August 22, 2022 20:30
@vrutkovs
Copy link
Contributor

vrutkovs commented Aug 22, 2022

/retest

@vrutkovs
Copy link
Contributor

vrutkovs commented Aug 23, 2022

/test e2e-nutanix

@vrutkovs
Copy link
Contributor

vrutkovs commented Aug 23, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

@vrutkovs: This pull request references Bugzilla bug 2109538, which is invalid:

  • expected the bug to target the "4.11.z" release, but it targets "4.12.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 2109538 to depend on a bug targeting a release in 4.12.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gpei
Copy link
Contributor

gpei commented Aug 23, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 23, 2022
@vrutkovs
Copy link
Contributor

vrutkovs commented Aug 23, 2022 •
edited by openshift-ci bot
Loading

/retitle [release-4.11] OCPBUGS-433: nutanix: allow creating manifests without Prism Central connection

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2109538: nutanix: allow creating manifests without Prism Central connection [release-4.11] OCPBUGS-433: nutanix: allow creating manifests without Prism Central connection Aug 23, 2022
@openshift-ci openshift-ci bot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 23, 2022
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Aug 23, 2022
@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022 •
edited
Loading

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] OCPBUGS-433: nutanix: allow creating manifests without Prism Central connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 23, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue OCPBUGS-433](https://issues.redhat.com//browse/OCPBUGS-433), which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)
  • dependent bug Jira Issue OCPBUGS-431 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-431 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents
Details

In response to this:

This is an automated cherry-pick of #6149

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor

vrutkovs commented Aug 23, 2022

/test e2e-nutanix

@vrutkovs
Copy link
Contributor

vrutkovs commented Aug 23, 2022

/cc @rvanderp3 @patrickdillon

@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 29, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 29, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 29, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@rvanderp3
Copy link
Contributor

rvanderp3 commented Aug 29, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-nutanix f60ac74 link false /test e2e-nutanix
ci/prow/e2e-libvirt f60ac74 link false /test e2e-libvirt
ci/prow/okd-e2e-aws f60ac74 link false /test okd-e2e-aws
ci/prow/e2e-ibmcloud f60ac74 link false /test e2e-ibmcloud
ci/prow/e2e-crc f60ac74 link false /test e2e-crc
ci/prow/e2e-openstack f60ac74 link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 29, 2022

/retest-required

Remaining retests: 2 against base HEAD e5d412b and 8 for PR HEAD f60ac74 in total

@openshift-merge-robot openshift-merge-robot merged commit 701ca84 into openshift:release-4.11 Aug 30, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 30, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-433 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6149

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbacbd barbacbd Awaiting requested review from barbacbd

@sadasu sadasu Awaiting requested review from sadasu

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@vrutkovs vrutkovs

@rvanderp3 rvanderp3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @vrutkovs @gpei @openshift-ci-robot @patrickdillon @rvanderp3 @openshift-merge-robot