manifests: Pass the NetworkProjectID to manifests #6242
Conversation
|
This is a copy/mirror of #6205 as the rebase cause github think the PR was merged. |
|
/cc jstuever |
|
/cc patrickdillon |
|
/test gofmt |
|
/test e2e-azure |
** Pull the NetworkProjectID out of the installconfig and pass it to the cloud provider manifests ** Added tests for the new manifest information ** Added the network project ID to match that of https://github.com/openshift/origin/blob/57b52e0a9528027448422d678c4ef682dfc0b885/vendor/k8s.io/legacy-cloud-providers/gce/gce.go#L136 CORS-2037 Alated
|
/test verify-codegen |
|
/test okd-e2e-aws |
|
/approve LGTM but hopefully we can get a good test run |
openshift-ci
bot
added
the
approved
r4f4
left a comment
r4f4
left a comment
There was a problem hiding this comment.
/lgtm
All the gcp jobs passed the installation phase.
/hold
In case @patrickdillon wants to double check the results.
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-libvirt |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-libvirt DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test images |
|
/retest |
|
/retest gofmt okd-unit okd-verify-codegen |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/test gofmt |
|
/test e2e-openstack |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp |
|
/test e2e-gcp |
|
/skip |
|
@barbacbd: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
** Pull the NetworkProjectID out of the installconfig and pass it to the cloud provider manifests
** Added tests for the new manifest information
** Added the network project ID to match that of
https://github.com/openshift/origin/blob/57b52e0a9528027448422d678c4ef682dfc0b885/vendor/k8s.io/legacy-cloud-providers/gce/gce.go#L136
CORS-2037