Skip to content

manifests/gcp: Added Network Project ID to the manifest #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barbacbd merged 0 commits into from
Aug 18, 2022
Merged

manifests/gcp: Added Network Project ID to the manifest #6205

barbacbd merged 0 commits into from
Aug 18, 2022

Conversation

@barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Aug 5, 2022 •
edited by openshift-ci bot
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2022
@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 5, 2022

requires #6166

@openshift-ci openshift-ci bot requested review from jstuever and rna-afk August 5, 2022 19:55
@barbacbd barbacbd force-pushed the add_network_project_id_to_manifest branch from 322754c to 2b6e97b Compare August 8, 2022 19:11
@barbacbd barbacbd changed the title WIP manifests/gcp: Added Network Project ID to the manifest manifests/gcp: Added Network Project ID to the manifest Aug 11, 2022
@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 11, 2022

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 11, 2022
@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 15, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2022
@barbacbd barbacbd force-pushed the add_network_project_id_to_manifest branch 2 times, most recently from a762443 to ac51f28 Compare August 15, 2022 16:41
jstuever
jstuever reviewed Aug 15, 2022
View reviewed changes
@barbacbd barbacbd force-pushed the add_network_project_id_to_manifest branch 3 times, most recently from ac51f28 to 9aa5da5 Compare August 16, 2022 15:47
@barbacbd barbacbd requested a review from jstuever August 16, 2022 15:47
@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 16, 2022

/cc patrickdillon

@openshift-ci openshift-ci bot requested a review from patrickdillon August 16, 2022 18:12
@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 16, 2022

/retest-required

patrickdillon
patrickdillon reviewed Aug 16, 2022
View reviewed changes
@barbacbd barbacbd force-pushed the add_network_project_id_to_manifest branch from 9aa5da5 to 6a9bfd1 Compare August 16, 2022 19:10
@barbacbd barbacbd requested a review from patrickdillon August 16, 2022 19:10
@patrickdillon
Copy link
Contributor

patrickdillon commented Aug 16, 2022

/approve

LGTM with a successful GCP test run

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@jstuever
Copy link
Contributor

jstuever commented Aug 18, 2022

/retest

@barbacbd barbacbd merged commit a8482db into openshift:master Aug 18, 2022
@barbacbd barbacbd force-pushed the add_network_project_id_to_manifest branch from c969e9a to e1959c2 Compare August 18, 2022 19:08
@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 18, 2022

/reopen

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2022

@barbacbd: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@barbacbd barbacbd mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rna-afk rna-afk Awaiting requested review from rna-afk

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barbacbd @patrickdillon @jstuever