Bug 2061947: IBMCloud: Skip DNS Record delete #6013

cjschaef · 2022-06-15T19:44:01Z

During uninstall/destroy, if no CIS CRN is available, the installer
errors trying to collect DNS Records for deletion. If no CIS CRN
is supplied in metadata, skip attempting to delete the DNS Records.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2061947

During uninstall/destroy, if no CIS CRN is available, the installer errors trying to collect DNS Records for deletion. If no CIS CRN is supplied in metadata, skip attempting to delete the DNS Records. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2061947

openshift-ci · 2022-06-15T19:44:51Z

@cjschaef: This pull request references Bugzilla bug 2061947, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @MayXuQQ

Details

In response to this:

Bug 2061947: IBMCloud: Skip DNS Record delete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cjschaef · 2022-06-15T19:45:24Z

With patch and empty cisInstanceCRN in metadata

# cat bz_2061947_clusters/bz-2061947-c6/metadata.json 
{"clusterName":"bz-2061947-c6","clusterID":"foo","infraID":"bz-2061947-c6-prkfx","ibmcloud":{"accountID":"foo","baseDomain":"ocp.cjschaef.com","cisInstanceCRN":"","region":"eu-gb","resourceGroupName":"bz-2061947-c6-prkfx"}}

# go/src/github.com/openshift/installer/bin/openshift-install destroy cluster --dir bz_2061947_clusters/bz-2061947-c6
INFO Stopped instance "bz-2061947-c6-prkfx-worker-2-9ht5d" 
...
INFO Skipping deletion of DNS Records, no CIS CRN found 
INFO Deleted COS instance "bz-2061947-c6-prkfx-image-registry" 
INFO Deleted COS instance "bz-2061947-c6-prkfx-cos" 
INFO Deleted resource group "bz-2061947-c6-prkfx" 
INFO Time elapsed: 5m41s

MayXuQQ · 2022-06-20T08:25:20Z

pre-merge test: registry.build05.ci.openshift.org/ci-ln-kgmc6xb/release:latest
destroyed the cluster newugd-14826-tgtrz
still can list the subnets:
$ ibmcloud resource search "name: newugd-14826-tgtrz*" | grep -E "Name|Type"
Name: newugd-14826-tgtrz-subnet-compute-us-east-1
Resource Type: subnet
Name: newugd-14826-tgtrz-subnet-control-plane-us-east-1
Resource Type: subnet
Name: newugd-14826-tgtrz-subnet-compute-us-east-3
Resource Type: subnet

/hold

MayXuQQ

subnets fail to be deleted.

cjschaef · 2022-06-21T14:11:26Z

@MayXuQQ
I performed additional testing, and I think the subnet failure above is unrelated, and caused by the known issue of orphaned service-instances for IBM Cloud resources instead.

I was able to confirm after 2 clean cluster creations, that all resources were properly deleted, except the DNS Records, when I manually removed the CIS CRN from the metadata.json prior to cluster destroy.

# cat bz_2061947_clusters/bz-2061947-c8/metadata.json 
{"clusterName":"bz-2061947-c8","clusterID":"7c200d3d-d7fc-49d9-9808-b539a407f062","infraID":"bz-2061947-c8-9r42t","ibmcloud":{"accountID":"foo","baseDomain":"ocp.cjschaef.com","cisInstanceCRN":"","region":"us-east","resourceGroupName":"bz-2061947-c8-9r42t"}}

# go/src/github.com/openshift/installer/bin/openshift-install destroy cluster --dir bz_2061947_clusters/bz-2061947-c8
INFO Stopped instance "bz-2061947-c8-9r42t-bootstrap"
...
INFO Deleted floating IP "bz-2061947-c8-9r42t-bootstrap-node-ip" 
INFO Deleted VPC "bz-2061947-c8-9r42t-vpc"        
INFO Skipping deletion of DNS Records, no CIS CRN found 
INFO Deleted resource group "bz-2061947-c8-9r42t" 
INFO Deleted COS instance "bz-2061947-c8-9r42t-cos" 
INFO Deleted COS instance "bz-2061947-c8-9r42t-image-registry" 
INFO Time elapsed: 6m8s

# ic resource search "name: bz-2061947-c8-9r42t"
No resources found

cjschaef · 2022-06-21T14:13:09Z

The e2e-ibmcloud test is expected to fail, since we still have yet to take the time to go through the OCP Conformance results to resolve all of the failing tests, to get a successful result, and fully "enable" the e2e testing for IBM Cloud (GA requirements have taken priority to this point).

MayXuQQ · 2022-06-21T14:51:27Z

/hold cancel
/label qe-approved
/bugzilla cc-qa

openshift-ci · 2022-06-21T14:52:59Z

@MayXuQQ: This pull request references Bugzilla bug 2061947, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @MayXuQQ

Details

In response to this:

/hold cancel
/label qe-approved
/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MayXuQQ

pre-merge test ok

patrickdillon · 2022-06-30T16:37:14Z

/approve
/lgtm

openshift-ci · 2022-06-30T16:46:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MayXuQQ, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-06-30T17:09:54Z

/retest-required

Remaining retests: 2 against base HEAD 2a61b87 and 8 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-06-30T19:30:00Z

/retest-required

Remaining retests: 1 against base HEAD 2a61b87 and 7 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-06-30T20:30:06Z

/retest-required

Remaining retests: 0 against base HEAD 2a61b87 and 6 for PR HEAD c6dbb39 in total

patrickdillon · 2022-07-01T14:42:29Z

/override e2e-aws
/override e2e-aws-upi

patrickdillon · 2022-07-01T14:44:59Z

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upi

openshift-ci · 2022-07-01T14:45:11Z

@patrickdillon: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

e2e-aws
e2e-aws-upi

Only the following contexts were expected:

ci/prow/aro-unit
ci/prow/e2e-aws
ci/prow/e2e-aws-upi
ci/prow/e2e-azure
ci/prow/e2e-azure-upi
ci/prow/e2e-gcp
ci/prow/e2e-gcp-upi
ci/prow/e2e-ibmcloud
ci/prow/e2e-vsphere
ci/prow/gofmt
ci/prow/golint
ci/prow/govet
ci/prow/images
ci/prow/okd-e2e-aws
ci/prow/okd-images
ci/prow/okd-unit
ci/prow/okd-verify-codegen
ci/prow/shellcheck
ci/prow/tf-fmt
ci/prow/tf-lint
ci/prow/unit
ci/prow/verify-codegen
ci/prow/verify-vendor
ci/prow/yaml-lint
pull-ci-openshift-installer-agent-installer-e2e-aws
pull-ci-openshift-installer-agent-installer-gofmt
pull-ci-openshift-installer-agent-installer-golint
pull-ci-openshift-installer-agent-installer-govet
pull-ci-openshift-installer-agent-installer-images
pull-ci-openshift-installer-agent-installer-unit
pull-ci-openshift-installer-agent-installer-verify-codegen
pull-ci-openshift-installer-agent-installer-verify-vendor
pull-ci-openshift-installer-fcos-e2e-gcp
pull-ci-openshift-installer-fcos-e2e-vsphere
pull-ci-openshift-installer-master-aro-unit
pull-ci-openshift-installer-master-e2e-aws-upi
pull-ci-openshift-installer-master-e2e-azure
pull-ci-openshift-installer-master-e2e-azure-upi
pull-ci-openshift-installer-master-e2e-gcp-upi
pull-ci-openshift-installer-master-e2e-ibmcloud
pull-ci-openshift-installer-master-okd-e2e-aws
pull-ci-openshift-installer-master-okd-images
pull-ci-openshift-installer-master-okd-unit
pull-ci-openshift-installer-master-okd-verify-codegen
pull-ci-openshift-installer-master-shellcheck
pull-ci-openshift-installer-master-tf-fmt
pull-ci-openshift-installer-master-tf-lint
pull-ci-openshift-installer-master-yaml-lint
tide

Details

In response to this:

/override e2e-aws
/override e2e-aws-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-01T14:50:42Z

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws, ci/prow/e2e-aws-upi

Details

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2022-07-01T15:04:43Z

/retest-required

patrickdillon · 2022-07-06T13:42:33Z

/hold cancel

openshift-ci-robot · 2022-07-06T14:20:55Z

/retest-required

Remaining retests: 2 against base HEAD c08429d and 8 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-06T18:52:33Z

/retest-required

Remaining retests: 2 against base HEAD e6ac416 and 7 for PR HEAD c6dbb39 in total

patrickdillon · 2022-07-06T20:26:25Z

/skip

openshift-ci-robot · 2022-07-06T22:52:23Z

/retest-required

Remaining retests: 2 against base HEAD b644753 and 6 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-07T02:52:26Z

/retest-required

Remaining retests: 1 against base HEAD b644753 and 5 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-07T06:52:22Z

/retest-required

Remaining retests: 2 against base HEAD 79abebb and 4 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-07T10:52:14Z

/retest-required

Remaining retests: 2 against base HEAD 03234c6 and 3 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-07T15:07:35Z

/retest-required

Remaining retests: 2 against base HEAD a0108db and 2 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-07T18:30:54Z

/retest-required

Remaining retests: 1 against base HEAD a0108db and 1 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-07T22:19:22Z

/retest-required

Remaining retests: 0 against base HEAD a0108db and 0 for PR HEAD c6dbb39 in total

openshift-ci-robot · 2022-07-08T02:06:18Z

/hold

Revision c6dbb39 was retested 9 times: holding

patrickdillon · 2022-07-11T14:05:47Z

/skip

patrickdillon · 2022-07-11T14:06:11Z

/hold cancel

openshift-ci-robot · 2022-07-11T15:33:23Z

/retest-required

Remaining retests: 2 against base HEAD b0502c5 and 8 for PR HEAD c6dbb39 in total

patrickdillon · 2022-07-11T16:55:01Z

/retest
/skip

jeffnowicki · 2022-07-11T18:22:34Z

/retest-required

openshift-ci-robot · 2022-07-11T21:20:15Z

/retest-required

Remaining retests: 1 against base HEAD b0502c5 and 7 for PR HEAD c6dbb39 in total

jeffnowicki · 2022-07-12T00:09:15Z

/skip
/retest-required

openshift-ci-robot · 2022-07-12T02:41:21Z

/retest-required

Remaining retests: 0 against base HEAD b0502c5 and 6 for PR HEAD c6dbb39 in total

patrickdillon · 2022-07-12T10:46:42Z

/override ci/prow/e2e-aws

openshift-ci · 2022-07-12T10:50:52Z

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-12T10:50:53Z

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud	`c6dbb39`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-gcp	`c6dbb39`	link	true	`/test e2e-gcp`
ci/prow/e2e-azure-upi	`c6dbb39`	link	true	`/test e2e-azure-upi`
ci/prow/e2e-aws	`c6dbb39`	link	true	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-07-12T10:53:18Z

@cjschaef: All pull requests linked via external trackers have merged:

openshift/installer#6013

Bugzilla bug 2061947 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2061947: IBMCloud: Skip DNS Record delete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 15, 2022

openshift-ci bot requested a review from MayXuQQ June 15, 2022 19:45

openshift-ci bot requested review from jstuever and r4f4 June 15, 2022 19:47

MayXuQQ suggested changes Jun 20, 2022

View reviewed changes

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 21, 2022

openshift-ci bot requested a review from MayXuQQ June 21, 2022 14:53

MayXuQQ approved these changes Jun 21, 2022

View reviewed changes

openshift-ci bot assigned patrickdillon Jun 30, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022

openshift-ci bot merged commit 09e92dc into openshift:master Jul 12, 2022

cjschaef deleted the bz_2061947 branch July 12, 2022 14:29

openshift-ci bot mentioned this pull request Aug 23, 2022

Bug 2061947: IBMCloud: Handle missing RG #6152

Merged

Bug 2061947: IBMCloud: Skip DNS Record delete #6013

Bug 2061947: IBMCloud: Skip DNS Record delete #6013

Uh oh!

Conversation

cjschaef commented Jun 15, 2022

Uh oh!

openshift-ci bot commented Jun 15, 2022

Uh oh!

cjschaef commented Jun 15, 2022

Uh oh!

MayXuQQ commented Jun 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MayXuQQ left a comment

Choose a reason for hiding this comment

Uh oh!

cjschaef commented Jun 21, 2022

Uh oh!

cjschaef commented Jun 21, 2022

Uh oh!

MayXuQQ commented Jun 21, 2022

Uh oh!

openshift-ci bot commented Jun 21, 2022

Uh oh!

MayXuQQ left a comment

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Jun 30, 2022

Uh oh!

openshift-ci bot commented Jun 30, 2022

Uh oh!

openshift-ci-robot commented Jun 30, 2022

Uh oh!

openshift-ci-robot commented Jun 30, 2022

Uh oh!

openshift-ci-robot commented Jun 30, 2022

Uh oh!

patrickdillon commented Jul 1, 2022

Uh oh!

patrickdillon commented Jul 1, 2022

Uh oh!

openshift-ci bot commented Jul 1, 2022

Uh oh!

openshift-ci bot commented Jul 1, 2022

Uh oh!

patrickdillon commented Jul 1, 2022

Uh oh!

patrickdillon commented Jul 6, 2022

Uh oh!

openshift-ci-robot commented Jul 6, 2022

Uh oh!

openshift-ci-robot commented Jul 6, 2022

Uh oh!

patrickdillon commented Jul 6, 2022

Uh oh!

openshift-ci-robot commented Jul 6, 2022

Uh oh!

openshift-ci-robot commented Jul 7, 2022

Uh oh!

openshift-ci-robot commented Jul 7, 2022

Uh oh!

openshift-ci-robot commented Jul 7, 2022

Uh oh!

openshift-ci-robot commented Jul 7, 2022

Uh oh!

openshift-ci-robot commented Jul 7, 2022

Uh oh!

openshift-ci-robot commented Jul 7, 2022

Uh oh!

openshift-ci-robot commented Jul 8, 2022

Uh oh!

patrickdillon commented Jul 11, 2022

Uh oh!

patrickdillon commented Jul 11, 2022

Uh oh!

openshift-ci-robot commented Jul 11, 2022

Uh oh!

patrickdillon commented Jul 11, 2022

Uh oh!

jeffnowicki commented Jul 11, 2022

MayXuQQ commented Jun 20, 2022 •

edited

Loading