Power VS: Use bucket name from coreos stream rather than inferring it #5782
Conversation
openshift-ci
bot
added
the
needs-rebase
|
This change is lower priority than the other Power VS PRs. How we're currently inferring the bucket name should be fine for now, but this will make it more future proof. |
staebler
left a comment
staebler
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold for the dependent PRs to merge
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
mjturek
force-pushed
the
powervs-use-bucket-name
branch
from
51044c2 to
ed66248
Compare
openshift-ci
bot
removed
lgtm
mjturek
force-pushed
the
powervs-use-bucket-name
branch
2 times, most recently
from
dcd0921 to
1f5c930
Compare
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/test openstack-manifests |
|
/test okd-images |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/skip |
|
/test e2e-metal-ipi-ovn-ipv6 |
2 similar comments
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-metal-ipi-ovn-ipv6 |
openshift-ci
bot
added
the
needs-rebase
|
/test e2e-metal-ipi-ovn-ipv6 |
|
@mjturek i think all the dependencies have been merged, but this needs a rebase |
mjturek
force-pushed
the
powervs-use-bucket-name
branch
from
1f5c930 to
c1c4e60
Compare
mjturek
force-pushed
the
powervs-use-bucket-name
branch
from
be96593 to
56c8e54
Compare
|
I’ve been having trouble with the |
|
I think there's a problem with the test and we should be able to merge this since these changes have no effect on metal work. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@mjturek: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
/refresh |
|
/override ci/prow/e2e-aws |
|
@rna-afk: rna-afk unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
For the Power VS provider, we currently infer the name of the bucket holding the image we import. However, the bucket name is available directly from the coreos stream metadata. We should use this in case the format of the bucket name ever changes.