Use bucket name from coreos stream rather than inferring it #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently infer the name of the bucket holding the image we import. However, the bucket name is available directly from the coreos stream metadata. We should use this in case the format of the bucket name ever changes.
mjturek
force-pushed
the
use-image-bucket-name
branch
from
99fa6ae to
15ad2ee
Compare
Author
Working, but we can submit after TF data patch merges if we want to avoid extra pushes to that PR |
|
can you submit this upstream as well? just put a comment that it's a lower-priority one. |
Author
|
Done openshift#5782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently infer the name of the bucket holding the image we import. However, the bucket name is available directly from the coreos stream metadata [0]. We should use this in case the format of the bucket name ever changes.
[0] https://github.com/coreos/stream-metadata-go/blob/main/stream/stream.go#L101