Skip to content

Conversation

@patrickdillon
Copy link
Contributor

Noticed a refactoring opportunity when reviewing #5756.

Depends on #5756

@patrickdillon patrickdillon force-pushed the refactor-ultrassd-tfvar branch from a727c91 to aff4aba Compare April 1, 2022 15:42
@patrickdillon
Copy link
Contributor Author

#5756 has merged so this is ready to go

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-proxy a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-aws-proxy
ci/prow/e2e-libvirt a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-libvirt
ci/prow/e2e-aws-disruptive a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-aws-disruptive
ci/prow/okd-e2e-aws-upgrade a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-gcp-upi-xpn a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-gcp-upi-xpn
ci/prow/e2e-crc a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-crc
ci/prow/e2e-gcp-shared-vpc a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-gcp-shared-vpc
ci/prow/e2e-alibaba a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-alibaba
ci/prow/e2e-metal-ipi-ovn-ipv6 a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-openstack a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-openstack
ci/prow/okd-e2e-aws a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test okd-e2e-aws
ci/prow/e2e-aws-single-node a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel8 a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-fips a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-aws-fips
ci/prow/e2e-aws a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link true /test e2e-aws
ci/prow/e2e-openstack-proxy a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-openstack-proxy
ci/prow/e2e-gcp a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-gcp
ci/prow/e2e-ibmcloud a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-ibmcloud
ci/prow/e2e-openstack-parallel a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-openstack-parallel
ci/prow/e2e-aws-shared-vpc a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link false /test e2e-aws-shared-vpc
ci/prow/e2e-gcp-upgrade a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-upgrade a727c9160fe0f5ab1573d7a48961c9e9eb561c69 link true /test e2e-aws-upgrade
ci/prow/e2e-azurestack aff4aba link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Apr 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@patrickdillon
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c6e22e5 into openshift:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants