Skip to content

vendor: update api to latest version to use AzureUltraSSDCapabilityEnabled #5756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 31, 2022
Merged

vendor: update api to latest version to use AzureUltraSSDCapabilityEnabled #5756

openshift-merge-robot merged 1 commit into from
Mar 31, 2022

Conversation

@jstuever
Copy link
Contributor

@jstuever jstuever commented Mar 28, 2022

The name of a constant was changed in the OpenShift API related to the
UltraSSD work. This change updates the API and modifies the usage of
that constant to reflect the new name: AzureUltraSSDCapabilityEnabled

https://issues.redhat.com/browse/CORS-1894

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2022
@jstuever jstuever force-pushed the cors1894 branch 2 times, most recently from 7977a09 to 4a991f5 Compare March 28, 2022 20:08
@jstuever jstuever changed the title WIP: api: update to latest version to use AzureUltraSSDCapabilityEnabled vendor: update api to latest version to use AzureUltraSSDCapabilityEnabled Mar 28, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2022
@jstuever
api: update to latest version to use AzureUltraSSDCapabilityEnabled
5c0936a 
The name of a constant was changed in the OpenShift API related to the
UltraSSD work. This change updates the API and modifies the usage of
that constant to reflect the new name: AzureUltraSSDCapabilityEnabled
@jhixson74
Copy link
Member

jhixson74 commented Mar 29, 2022

/lgtm looks straight forward to me

patrickdillon
patrickdillon reviewed Mar 29, 2022
View reviewed changes
@jstuever
Copy link
Contributor Author

jstuever commented Mar 29, 2022

/retest

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 29, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@njhale njhale mentioned this pull request Mar 29, 2022
Closed
@patrickdillon patrickdillon mentioned this pull request Mar 29, 2022
Merged
@jhixson74
Copy link
Member

jhixson74 commented Mar 30, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 30, 2022

/skip

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 30, 2022

/override ci/prow/e2e-aws

I see no way this PR is responsible for this test failure

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

I see no way this PR is responsible for this test failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 31, 2022

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-gcp-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws-upgrade, ci/prow/e2e-gcp-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit beefeac into openshift:master Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

@jstuever: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-proxy 5c0936a link false /test e2e-aws-proxy
ci/prow/e2e-aws-single-node 5c0936a link false /test e2e-aws-single-node
ci/prow/e2e-vsphere 5c0936a link false /test e2e-vsphere
ci/prow/e2e-aws-fips 5c0936a link false /test e2e-aws-fips
ci/prow/e2e-gcp-upi-xpn 5c0936a link false /test e2e-gcp-upi-xpn
ci/prow/e2e-alibaba 5c0936a link false /test e2e-alibaba
ci/prow/okd-e2e-aws-upgrade 5c0936a link false /test okd-e2e-aws-upgrade
ci/prow/e2e-openstack 5c0936a link false /test e2e-openstack
ci/prow/e2e-ibmcloud 5c0936a link false /test e2e-ibmcloud
ci/prow/e2e-openstack-parallel 5c0936a link false /test e2e-openstack-parallel
ci/prow/e2e-libvirt 5c0936a link false /test e2e-libvirt
ci/prow/e2e-gcp-shared-vpc 5c0936a link false /test e2e-gcp-shared-vpc
ci/prow/e2e-aws-shared-vpc 5c0936a link false /test e2e-aws-shared-vpc
ci/prow/e2e-openstack-proxy 5c0936a link false /test e2e-openstack-proxy
ci/prow/e2e-crc 5c0936a link false /test e2e-crc
ci/prow/e2e-aws-disruptive 5c0936a link false /test e2e-aws-disruptive
ci/prow/e2e-aws-workers-rhel8 5c0936a link false /test e2e-aws-workers-rhel8
ci/prow/e2e-azurestack 5c0936a link false /test e2e-azurestack
ci/prow/okd-e2e-aws 5c0936a link false /test okd-e2e-aws
ci/prow/e2e-metal-ipi-ovn-ipv6 5c0936a link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws 5c0936a link unknown /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever jstuever deleted the cors1894 branch May 3, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@jhixson74 jhixson74

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jstuever @jhixson74 @patrickdillon @openshift-bot @openshift-merge-robot