Bug 2065808: stop considering Mint mode as supported on Azure (#5699) #5717

r4f4 · 2022-03-16T20:52:07Z

Co-authored-by: Joel Diaz [email protected]

Co-authored-by: Joel Diaz <[email protected]>

openshift-ci · 2022-03-16T20:52:09Z

@r4f4: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

stop considering Mint mode as supported on Azure (#5699)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2022-03-16T20:52:36Z

/cherry-pick release-4.9
/cherry-pick release-4.8

openshift-cherrypick-robot · 2022-03-16T20:52:37Z

@r4f4: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.9
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2022-03-17T00:57:37Z

@r4f4 what you should do is create a bugzilla for #5699 and then cherry pick from that PR. The bot will create the needed bugzillas correctly. Let me know if I can help you with that.

r4f4 · 2022-03-17T08:53:40Z

@r4f4 what you should do is create a bugzilla for #5699 and then cherry pick from that PR. The bot will create the needed bugzillas correctly. Let me know if I can help you with that.

@patrickdillon I tried cherry-picking from the PR but there are merge conflicts #5699 (comment). That's why I did the cherry-pick manually and submitted a new PR.

patrickdillon · 2022-03-18T18:28:22Z

I tried cherry-picking from the PR but there are merge conflicts #5699 (comment). That's why I did the cherry-pick manually and submitted a new PR.

Got it, then this is correct. You will still need to create a BZ for the master branch for the cherry picks.

openshift-ci · 2022-03-18T18:56:50Z

@r4f4: This pull request references Bugzilla bug 2065808, which is invalid:

expected dependent Bugzilla bug 2065806 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2065808: stop considering Mint mode as supported on Azure (#5699)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianping-shu · 2022-03-21T05:00:09Z

Verified with Flexy-install with the following LAUNCHER_VARS:
credentials_mode: "Mint"
installer_payload_image: registry.build01.ci.openshift.org/ci-ln-8wg6m9k/release:latest(build #5717)

The install failed with the following error info, Passed

03-21 11:00:13.294 [INFO] Generating manifests files.....
03-21 11:00:13.294 level=fatal msg=failed to fetch Master Machines: failed to load asset "Install Config": invalid "install-config.yaml" file: credentialsMode: Unsupported value: "Mint": supported values: "Manual", "Passthrough"

jianping-shu · 2022-03-21T05:02:22Z

/label qe-approved

jianping-shu · 2022-03-21T05:05:12Z

/label cherry-pick-approved

openshift-ci · 2022-03-21T05:05:13Z

@jianping-shu: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gpei · 2022-03-21T06:20:11Z

/label cherry-pick-approved

r4f4 · 2022-03-21T08:08:35Z

/bugzilla refresh

openshift-ci · 2022-03-21T08:08:39Z

@r4f4: This pull request references Bugzilla bug 2065808, which is invalid:

expected the bug to target the "4.10.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2022-03-21T08:31:34Z

/bugzilla refresh

openshift-ci · 2022-03-21T08:31:44Z

@r4f4: This pull request references Bugzilla bug 2065808, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.z) matches configured target release for branch (4.10.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2065806 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2065806 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianping-shu · 2022-03-22T02:33:24Z

Verification done, passed

r4f4 · 2022-03-22T07:39:10Z

/assign @staebler

staebler

/lgtm
/approve
/labal backport-risk-assessed

openshift-ci · 2022-03-22T13:40:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

staebler · 2022-03-22T14:01:19Z

/label backport-risk-assessed

r4f4 · 2022-03-22T14:16:49Z

/test e2e-aws

openshift-bot · 2022-03-22T16:02:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T17:14:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T19:14:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T20:15:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T23:06:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T23:54:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T00:31:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T00:44:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T01:22:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T02:26:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T03:14:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-23T03:33:43Z

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-crc	`db171bf`	link	false	`/test e2e-crc`
ci/prow/e2e-azurestack	`db171bf`	link	false	`/test e2e-azurestack`
ci/prow/okd-e2e-gcp	`db171bf`	link	false	`/test okd-e2e-gcp`
ci/prow/okd-e2e-gcp-upgrade	`db171bf`	link	false	`/test okd-e2e-gcp-upgrade`
ci/prow/e2e-openstack-kuryr	`db171bf`	link	false	`/test e2e-openstack-kuryr`
ci/prow/okd-e2e-aws-upgrade	`db171bf`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-alibaba	`db171bf`	link	false	`/test e2e-alibaba`
ci/prow/okd-e2e-vsphere	`db171bf`	link	false	`/test okd-e2e-vsphere`
ci/prow/e2e-ibmcloud	`db171bf`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-azurestack-upi	`db171bf`	link	false	`/test e2e-azurestack-upi`
ci/prow/e2e-azure-upi	`db171bf`	link	false	`/test e2e-azure-upi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-03-23T04:42:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T05:43:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T06:43:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-23T07:11:24Z

@r4f4: All pull requests linked via external trackers have merged:

openshift/installer#5717

Bugzilla bug 2065808 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2065808: stop considering Mint mode as supported on Azure (#5699)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-03-23T07:12:46Z

@r4f4: #5717 failed to apply on top of branch "release-4.9":

Applying: stop considering Mint mode as supported on Azure (#5699)
Using index info to reconstruct a base tree...
M	data/data/install.openshift.io_installconfigs.yaml
M	pkg/explain/printer_test.go
M	pkg/types/installconfig.go
M	pkg/types/validation/installconfig.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/types/validation/installconfig.go
Auto-merging pkg/types/installconfig.go
Auto-merging pkg/explain/printer_test.go
CONFLICT (content): Merge conflict in pkg/explain/printer_test.go
Auto-merging data/data/install.openshift.io_installconfigs.yaml
CONFLICT (content): Merge conflict in data/data/install.openshift.io_installconfigs.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 stop considering Mint mode as supported on Azure (#5699)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.9
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-03-23T07:14:14Z

@r4f4: #5717 failed to apply on top of branch "release-4.8":

Applying: stop considering Mint mode as supported on Azure (#5699)
Using index info to reconstruct a base tree...
M	data/data/install.openshift.io_installconfigs.yaml
M	pkg/explain/printer_test.go
M	pkg/types/installconfig.go
M	pkg/types/validation/installconfig.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/types/validation/installconfig.go
CONFLICT (content): Merge conflict in pkg/types/validation/installconfig.go
Auto-merging pkg/types/installconfig.go
CONFLICT (content): Merge conflict in pkg/types/installconfig.go
Auto-merging pkg/explain/printer_test.go
CONFLICT (content): Merge conflict in pkg/explain/printer_test.go
Auto-merging data/data/install.openshift.io_installconfigs.yaml
CONFLICT (content): Merge conflict in data/data/install.openshift.io_installconfigs.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 stop considering Mint mode as supported on Azure (#5699)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.9
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stop considering Mint mode as supported on Azure (openshift#5699)

db171bf

Co-authored-by: Joel Diaz <[email protected]>

openshift-ci bot requested review from jhixson74 and rna-afk March 16, 2022 20:53

r4f4 changed the title ~~stop considering Mint mode as supported on Azure (#5699)~~ Bug 2065808: stop considering Mint mode as supported on Azure (#5699) Mar 18, 2022

openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 18, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 21, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 21, 2022

openshift-ci bot requested a review from jianping-shu March 21, 2022 08:31

openshift-ci bot assigned staebler Mar 22, 2022

staebler reviewed Mar 22, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 22, 2022

openshift-merge-robot merged commit 6e3ddd3 into openshift:release-4.10 Mar 23, 2022

Bug 2065808: stop considering Mint mode as supported on Azure (#5699) #5717

Bug 2065808: stop considering Mint mode as supported on Azure (#5699) #5717

Uh oh!

Conversation

r4f4 commented Mar 16, 2022

Uh oh!

openshift-ci bot commented Mar 16, 2022

Uh oh!

r4f4 commented Mar 16, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 16, 2022

Uh oh!

patrickdillon commented Mar 17, 2022

Uh oh!

r4f4 commented Mar 17, 2022

Uh oh!

patrickdillon commented Mar 18, 2022

Uh oh!

openshift-ci bot commented Mar 18, 2022

Uh oh!

jianping-shu commented Mar 21, 2022

Uh oh!

jianping-shu commented Mar 21, 2022

Uh oh!

jianping-shu commented Mar 21, 2022

Uh oh!

openshift-ci bot commented Mar 21, 2022

Uh oh!

gpei commented Mar 21, 2022

Uh oh!

r4f4 commented Mar 21, 2022

Uh oh!

openshift-ci bot commented Mar 21, 2022

Uh oh!

r4f4 commented Mar 21, 2022

Uh oh!

openshift-ci bot commented Mar 21, 2022

Uh oh!

jianping-shu commented Mar 22, 2022

Uh oh!

r4f4 commented Mar 22, 2022

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 22, 2022

Uh oh!

staebler commented Mar 22, 2022

Uh oh!

r4f4 commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-ci bot commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

openshift-ci bot commented Mar 23, 2022 •

edited

Loading