Bug 2065806: stop considering Mint mode as supported on Azure #5699

r4f4 · 2022-03-11T16:41:11Z

This PR is just #5496 with merge conflicts resolved.

r4f4 · 2022-03-11T21:59:57Z

/retest-required

Fix printer_test

staebler

/lgtm
/approve

openshift-ci · 2022-03-16T02:13:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-03-16T03:11:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-16T05:23:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-16T05:47:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-16T06:35:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-16T07:47:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-16T09:36:03Z

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud	`10fb2bb`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-ovirt	`10fb2bb`	link	false	`/test e2e-ovirt`
ci/prow/e2e-metal-ipi-ovn-ipv6	`10fb2bb`	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-crc	`10fb2bb`	link	false	`/test e2e-crc`
ci/prow/okd-e2e-aws-upgrade	`10fb2bb`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-azure-upi	`10fb2bb`	link	false	`/test e2e-azure-upi`
ci/prow/e2e-aws-single-node	`10fb2bb`	link	false	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-03-16T11:37:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

staebler · 2022-03-16T11:47:37Z

/label tide/merge-merhod-squash

openshift-ci · 2022-03-16T11:47:38Z

@staebler: The label(s) /label tide/merge-merhod-squash cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

Details

In response to this:

/label tide/merge-merhod-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-16T13:01:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-16T14:13:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-16T18:01:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-16T18:26:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

r4f4 · 2022-03-16T20:21:45Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-03-16T20:24:00Z

@r4f4: #5699 failed to apply on top of branch "release-4.10":

Applying: stop considering Mint mode as supported on Azure
Using index info to reconstruct a base tree...
M	data/data/install.openshift.io_installconfigs.yaml
M	pkg/types/installconfig.go
M	pkg/types/validation/installconfig.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/types/validation/installconfig.go
Auto-merging pkg/types/installconfig.go
Auto-merging data/data/install.openshift.io_installconfigs.yaml
CONFLICT (content): Merge conflict in data/data/install.openshift.io_installconfigs.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 stop considering Mint mode as supported on Azure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Joel Diaz <[email protected]>

openshift-ci · 2022-03-18T18:45:58Z

@r4f4: All pull requests linked via external trackers have merged:

Bugzilla bug 2065806 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2065806: stop considering Mint mode as supported on Azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2022-03-18T18:46:41Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-03-18T18:48:06Z

@r4f4: #5699 failed to apply on top of branch "release-4.10":

Applying: stop considering Mint mode as supported on Azure
Using index info to reconstruct a base tree...
M	data/data/install.openshift.io_installconfigs.yaml
M	pkg/types/installconfig.go
M	pkg/types/validation/installconfig.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/types/validation/installconfig.go
Auto-merging pkg/types/installconfig.go
Auto-merging data/data/install.openshift.io_installconfigs.yaml
CONFLICT (content): Merge conflict in data/data/install.openshift.io_installconfigs.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 stop considering Mint mode as supported on Azure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 2065808: stop considering Mint mode as supported on Azure (#5699)

Co-authored-by: Joel Diaz <[email protected]>

Bug 2067092: stop considering Mint mode as supported on Azure (#5699)

Co-authored-by: Joel Diaz <[email protected]>

Bug 2069166: stop considering Mint mode as supported on Azure (#5699)

openshift-ci bot requested review from jhixson74 and kirankt March 11, 2022 16:46

stop considering Mint mode as supported on Azure

4923970

r4f4 force-pushed the no-more-azure-mint branch from c4ba012 to 4923970 Compare March 14, 2022 19:26

fixup! stop considering Mint mode as supported on Azure

10fb2bb

Fix printer_test

staebler reviewed Mar 16, 2022

View reviewed changes

openshift-ci bot assigned staebler Mar 16, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022

staebler added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 16, 2022

openshift-merge-robot merged commit 3e1f7c4 into openshift:master Mar 16, 2022

r4f4 added a commit to r4f4/installer that referenced this pull request Mar 16, 2022

stop considering Mint mode as supported on Azure (openshift#5699)

db171bf

Co-authored-by: Joel Diaz <[email protected]>

openshift-ci bot mentioned this pull request Mar 16, 2022

Bug 2065808: stop considering Mint mode as supported on Azure (#5699) #5717

Merged

patrickdillon mentioned this pull request Mar 17, 2022

stop considering Mint mode as supported on Azure #5496

Closed

r4f4 changed the title ~~stop considering Mint mode as supported on Azure~~ Bug 2065806: stop considering Mint mode as supported on Azure Mar 18, 2022

openshift-merge-robot added a commit that referenced this pull request Mar 23, 2022

Merge pull request #5717 from r4f4/cherry-pick-5699-to-release-4.10

6e3ddd3

Bug 2065808: stop considering Mint mode as supported on Azure (#5699)

r4f4 added a commit to r4f4/installer that referenced this pull request Mar 23, 2022

stop considering Mint mode as supported on Azure (openshift#5699)

fc75447

Co-authored-by: Joel Diaz <[email protected]>

openshift-ci bot mentioned this pull request Mar 23, 2022

Bug 2067092: stop considering Mint mode as supported on Azure (#5699) #5738

Merged

openshift-merge-robot added a commit that referenced this pull request Mar 27, 2022

Merge pull request #5738 from r4f4/cherry-pick-5699-to-release-4.9

c7a4599

Bug 2067092: stop considering Mint mode as supported on Azure (#5699)

r4f4 added a commit to r4f4/installer that referenced this pull request Mar 28, 2022

stop considering Mint mode as supported on Azure (openshift#5699)

1f771f4

Co-authored-by: Joel Diaz <[email protected]>

openshift-ci bot mentioned this pull request Mar 28, 2022

Bug 2069166: stop considering Mint mode as supported on Azure (#5699) #5753

Merged

openshift-merge-robot added a commit that referenced this pull request Apr 6, 2022

Merge pull request #5753 from r4f4/cherry-pick-5699-to-release-4.8

45c6c1d

Bug 2069166: stop considering Mint mode as supported on Azure (#5699)

Bug 2065806: stop considering Mint mode as supported on Azure #5699

Bug 2065806: stop considering Mint mode as supported on Azure #5699

Uh oh!

Conversation

r4f4 commented Mar 11, 2022

Uh oh!

r4f4 commented Mar 11, 2022

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-ci bot commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

staebler commented Mar 16, 2022

Uh oh!

openshift-ci bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

r4f4 commented Mar 16, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 16, 2022

Uh oh!

openshift-ci bot commented Mar 18, 2022

Uh oh!

r4f4 commented Mar 18, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci bot commented Mar 16, 2022 •

edited

Loading