Skip to content

Re-update BMO vendor to use ipxe for iRMC #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 7, 2022
Merged

Re-update BMO vendor to use ipxe for iRMC #5662

openshift-merge-robot merged 1 commit into from
Apr 7, 2022

Conversation

@hs0210
Copy link
Contributor

@hs0210 hs0210 commented Feb 25, 2022

#5588 was not included after #5507, re-update bmo vendor to use the fixed irmc boot_interface

Signed-off-by: Hu Shuai [email protected]

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2022

Hi @hs0210. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link

rhjanders commented Feb 28, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2022
@fenggw-fnst
Copy link

fenggw-fnst commented Feb 28, 2022

/retest

@hase1128
Copy link

hase1128 commented Mar 2, 2022

@rhjanders
This CI still fails in some tests.
However, all of these tests are not mandatory, so I believe we can proceed with this PR review.
How do you think about?

@dtantsur
Copy link
Member

dtantsur commented Mar 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2022
@elfosardo
Copy link
Contributor

elfosardo commented Mar 8, 2022

/retest
I can't approve but this looks ok to me

@elfosardo
Copy link
Contributor

elfosardo commented Mar 8, 2022

/retest

1 similar comment
@hase1128
Copy link

hase1128 commented Mar 9, 2022

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2022
@hs0210 hs0210 force-pushed the update-bmo-version branch from 5c097ae to 6454851 Compare March 14, 2022 01:03
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 14, 2022
@hs0210
Copy link
Contributor Author

hs0210 commented Mar 14, 2022

/retest

2 similar comments
@hase1128
Copy link

hase1128 commented Mar 15, 2022

/retest

@fenggw-fnst
Copy link

fenggw-fnst commented Mar 15, 2022

/retest

@andfasano
Copy link
Contributor

andfasano commented Mar 15, 2022

/retest-required

@hase1128
Copy link

hase1128 commented Mar 16, 2022

@andfasano
All mandatory tests has been passed. So I think we can proceed this PR for merge.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2022
@hs0210 hs0210 force-pushed the update-bmo-version branch from 6454851 to a60350d Compare March 21, 2022 01:29
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022
@hs0210
Copy link
Contributor Author

hs0210 commented Mar 21, 2022

/retest-required

1 similar comment
@hs0210
Copy link
Contributor Author

hs0210 commented Mar 21, 2022

/retest-required

@elfosardo
Copy link
Contributor

elfosardo commented Mar 22, 2022

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

20 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2022 •
edited
Loading

@hs0210: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 6809b29 link false /test e2e-crc
ci/prow/e2e-gcp 6809b29 link false /test e2e-gcp
ci/prow/e2e-ibmcloud 6809b29 link false /test e2e-ibmcloud
ci/prow/e2e-azurestack 6809b29 link false /test e2e-azurestack
ci/prow/e2e-alibaba 6809b29 link false /test e2e-alibaba
ci/prow/e2e-metal-ipi-ovn-ipv6 6809b29 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-single-node 6809b29 link false /test e2e-aws-single-node
ci/prow/okd-e2e-aws-upgrade 6809b29 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-metal-ipi-virtualmedia 6809b29 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-openstack-proxy 6809b29 link false /test e2e-openstack-proxy
ci/prow/e2e-aws-workers-rhel8 6809b29 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-shared-vpc 6809b29 link false /test e2e-aws-shared-vpc
ci/prow/e2e-openstack 6809b29 link false /test e2e-openstack
ci/prow/e2e-aws-disruptive 6809b29 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack 6809b29 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-proxy 6809b29 link false /test e2e-aws-proxy
ci/prow/e2e-gcp-shared-vpc 6809b29 link false /test e2e-gcp-shared-vpc
ci/prow/e2e-gcp-upi-xpn 6809b29 link false /test e2e-gcp-upi-xpn
ci/prow/okd-e2e-aws 6809b29 link false /test okd-e2e-aws
ci/prow/e2e-openstack-parallel 6809b29 link false /test e2e-openstack-parallel
ci/prow/e2e-metal-ipi 6809b29 link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-swapped-hosts 6809b29 link false /test e2e-metal-ipi-swapped-hosts
ci/prow/e2e-libvirt 6809b29 link false /test e2e-libvirt
ci/prow/e2e-azure 6809b29 link false /test e2e-azure
ci/prow/e2e-aws-upgrade 6809b29 link false /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 7, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f6a1b6e into openshift:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rna-afk rna-afk Awaiting requested review from rna-afk

1 more reviewer

@staebler staebler staebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dtantsur dtantsur

@elfosardo elfosardo

@staebler staebler

@rhjanders rhjanders

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.