Bug 2047925: Update BMO vendor #5588

hs0210 · 2022-01-28T16:36:56Z

Update BMO vendor to use the fixed irmc boot_interface

Signed-off-by: Hu Shuai [email protected]

Update BMO vendor to use the fixed irmc boot_interface Signed-off-by: Hu Shuai <[email protected]>

openshift-ci · 2022-01-28T16:37:34Z

Hi @hs0210. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hs0210 · 2022-01-28T16:47:21Z

@zaneb @dtantsur @derekhiggins @andfasano @rhjanders Hi, openshift-bmo-#200-irmc: change BootInterface to ipxe has been merged, this PR update the BMO vendor. PTAL.

zaneb · 2022-01-28T20:49:17Z

/retitle Bug 2041765: Update BMO vendor

openshift-ci · 2022-01-28T20:49:21Z

@hs0210: This pull request references Bugzilla bug 2041765, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2041765: Update BMO vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zaneb · 2022-01-28T21:12:32Z

Code freeze has passed, so I cloned the bug to 4.11. We'll have to backport this to the release-4.10 branch when it merges (we can use the original bug for that).
/retitle Bug 2047925: Update BMO vendor

openshift-ci · 2022-01-28T21:12:35Z

@hs0210: This pull request references Bugzilla bug 2047925, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2047925: Update BMO vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zaneb · 2022-01-28T21:13:29Z

/bugzilla refresh

openshift-ci · 2022-01-28T21:13:36Z

@zaneb: This pull request references Bugzilla bug 2047925, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zaneb · 2022-01-28T21:14:16Z

/ok-to-test

hs0210 · 2022-01-28T23:26:49Z

Code freeze has passed, so I cloned the bug to 4.11.

@zaneb Thanks very much!

We'll have to backport this to the release-4.10 branch when it merges (we can use the original bug for that).

Do you mean this PR can merge into release-4.10? We sincerely hope it can catch up release-4.10.

hs0210 · 2022-01-29T00:44:17Z

/retest

fenggw-fnst · 2022-01-29T06:44:16Z

/retest

hase1128 · 2022-01-31T01:38:39Z

We tested the latest nightly 4.10.0-0.nightly-2022-01-29-215708 with this PR, the result is as follows:

4.10.0-0.nightly-2022-01-29-215708 + PR5588(containing the ipxe fix and some other changes in vendor copy): FAIL
4.10.0-0.nightly-2022-01-29-215708 + only the ipxe fix: PASS

FAIL description: the install console ends up with following error message:

INFO Bootstrap gather logs captured here "/home/kni/clusterconfigs/log-bundle-20220130050923.tar.gz"ERROR Bootstrap failed to complete: timed out waiting for the condition
ERROR Failed to wait for bootstrapping to complete. This error usually happens when there is a problem with control plane hosts that prevents the control plane operators from creating the control plane.
FATAL Bootstrap failed to complete

But in the end, the OCP cluster can be successfully deployed and all Pods run normally.
It seems that the problem is caused by the other changes in PR5588's vendor copy.
We will do further investigation.

zaneb · 2022-01-31T15:16:57Z

/test e2e-metal-ipi-ovn-ipv6-required

wking · 2022-01-31T21:16:38Z

/bugzilla refresh

openshift-ci · 2022-01-31T21:16:42Z

@wking: This pull request references Bugzilla bug 2047925, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhouhao3 · 2022-02-08T02:44:10Z

/test e2e-metal-ipi-ovn-ipv6-required

zhouhao3 · 2022-02-08T02:58:28Z

/retest

hs0210 · 2022-02-08T06:34:04Z

/retest-required

hs0210 · 2022-02-08T07:59:42Z

@zaneb The error FATAL Bootstrap failed to complete mentioned above should be caused by the instability of our network environment, resulting in the waiting for bootstrap complete phase taking too long and timing out.

We tested it many times with the latest nightly(4.10.0-0.nightly-2022-01-31-012936)+#5588, sometimes the IPI succeeded. So we changed the timeout of waiting for bootstrap complete from 30 min to 60 min, and the next 4 tests all succeeded. And waiting for bootstrap complete took 28 min, 38 min, 28 min, and 39 min, respectively.

So #5588 itself should be fine, please continue to review.

hs0210 · 2022-02-08T09:59:04Z

/retest-required

zaneb · 2022-02-08T19:19:47Z

@kirankt I think this is ready for review. OpenStack and baremetal should be the only platforms affected, and those jobs are all passing.

kirankt

/lgtm

patrickdillon · 2022-02-08T20:16:23Z

/approve

openshift-ci · 2022-02-08T20:16:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirankt, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-02-08T20:34:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-08T20:58:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-02-08T22:36:56Z

@hs0210: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	`a603303`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-crc	`a603303`	link	false	`/test e2e-crc`
ci/prow/okd-e2e-aws-upgrade	`a603303`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-aws-workers-rhel8	`a603303`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-ibmcloud	`a603303`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-azure-upi	`a603303`	link	false	`/test e2e-azure-upi`
ci/prow/okd-e2e-aws	`a603303`	link	false	`/test okd-e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-02-08T22:38:23Z

@hs0210: All pull requests linked via external trackers have merged:

openshift/installer#5588

Bugzilla bug 2047925 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2047925: Update BMO vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhjanders · 2022-03-15T08:15:45Z

/cherrypick release-4.10

openshift-cherrypick-robot · 2022-03-15T08:17:25Z

@rhjanders: new pull request created: #5705

Details

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Update BMO vendor

a603303

Update BMO vendor to use the fixed irmc boot_interface Signed-off-by: Hu Shuai <[email protected]>

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 28, 2022

openshift-ci bot requested review from kirankt and rna-afk January 28, 2022 16:37

openshift-ci bot changed the title ~~Update BMO vendor~~ Bug 2041765: Update BMO vendor Jan 28, 2022

openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 28, 2022

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2022

openshift-ci bot changed the title ~~Bug 2041765: Update BMO vendor~~ Bug 2047925: Update BMO vendor Jan 28, 2022

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2022

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2022

kirankt approved these changes Feb 8, 2022

View reviewed changes

openshift-ci bot assigned kirankt Feb 8, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022

openshift-merge-robot merged commit 02ccd27 into openshift:master Feb 8, 2022

staebler mentioned this pull request Feb 21, 2022

isolate terraform #5507

Merged

5 tasks

hs0210 mentioned this pull request Feb 25, 2022

Re-update BMO vendor to use ipxe for iRMC #5662

Merged

hs0210 deleted the update-bmo-vendor branch February 28, 2022 03:18

openshift-cherrypick-robot mentioned this pull request Mar 15, 2022

[release-4.10] Bug 2041765: Update BMO vendor #5705

Merged

Bug 2047925: Update BMO vendor #5588

Bug 2047925: Update BMO vendor #5588

Uh oh!

Conversation

hs0210 commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

hs0210 commented Jan 28, 2022

Uh oh!

zaneb commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

zaneb commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

zaneb commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

zaneb commented Jan 28, 2022

Uh oh!

hs0210 commented Jan 28, 2022

Uh oh!

hs0210 commented Jan 29, 2022

Uh oh!

fenggw-fnst commented Jan 29, 2022

Uh oh!

hase1128 commented Jan 31, 2022

Uh oh!

zaneb commented Jan 31, 2022

Uh oh!

wking commented Jan 31, 2022

Uh oh!

openshift-ci bot commented Jan 31, 2022

Uh oh!

zhouhao3 commented Feb 8, 2022

Uh oh!

zhouhao3 commented Feb 8, 2022

Uh oh!

hs0210 commented Feb 8, 2022

Uh oh!

hs0210 commented Feb 8, 2022

Uh oh!

hs0210 commented Feb 8, 2022

Uh oh!

zaneb commented Feb 8, 2022

Uh oh!

kirankt left a comment

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Feb 8, 2022

Uh oh!

openshift-ci bot commented Feb 8, 2022

Uh oh!

openshift-bot commented Feb 8, 2022

Uh oh!

openshift-bot commented Feb 8, 2022

Uh oh!

openshift-ci bot commented Feb 8, 2022

Uh oh!

openshift-ci bot commented Feb 8, 2022

Uh oh!

rhjanders commented Mar 15, 2022

Uh oh!

openshift-cherrypick-robot commented Mar 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants