Add IBM Power VS: tfvars by clnperez · Pull Request #5615 · openshift/installer

clnperez · 2022-02-04T23:56:17Z

For more background on IPI on Power VS, refer to the enhancement
proposal here: openshift/enhancements#736

Older discussions on some of the code here can be found in #5224

Signed-off-by: Christy Norman christy@linux.vnet.ibm.com

clnperez · 2022-03-22T21:38:56Z

working on cleaning this up now that the others are in. got sidetracked

clnperez · 2022-03-23T13:05:49Z

@rna-afk @patrickdillon can you take a look at this one?

rna-afk · 2022-03-23T13:18:59Z

/lgtm

clnperez · 2022-03-24T16:46:09Z

tests seem stuck since yesterday
/retest

clnperez · 2022-03-24T19:09:40Z

i fixed the tf formatting. can you re-lgtm this @rna-afk ?

rna-afk · 2022-03-24T19:11:57Z

Could you move the rhcos changes to the first commit? I think just two commits are fine with one for vendoring and other for the code.

clnperez · 2022-03-24T21:55:18Z

done @rna-afk

clnperez · 2022-03-25T19:16:01Z

/retest-required

clnperez · 2022-03-29T15:01:01Z

/retest-required

clnperez · 2022-03-29T18:22:01Z

blergh. i'm out until tuesday (starting tomorrow) @patrickdillon could you approve this one?

and @Prashanth684 would you mind babysitting (/retest-required) if those keep failing?

clnperez · 2022-03-29T18:22:31Z

/retest-required

clnperez · 2022-04-06T15:14:53Z

just picked up the new nutanix provider. should be good again.

rna-afk · 2022-04-06T16:10:42Z

/lgtm

clnperez · 2022-04-06T20:17:30Z

aaaaand there's a new conflict. this will be fun :D

For more background on IPI on Power VS, refer to the enhancement proposal here: openshift/enhancements#736 Older discussions on some of the code here can be found in openshift#5224 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

specifically, we need to pick up this commit: coreos/stream-metadata-go@89bd6bc Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

clnperez · 2022-04-06T20:21:11Z

@rna-afk i think that's resolved now as well so will need that lgtm again

rna-afk · 2022-04-06T21:53:34Z

/lgtm

clnperez · 2022-04-07T13:18:51Z

/retest-required

clnperez · 2022-04-07T18:23:34Z

/retest-required

patrickdillon · 2022-04-11T15:46:30Z

/approve

openshift-ci · 2022-04-11T15:47:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-04-11T16:14:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-11T16:40:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-11T18:24:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-11T19:16:18Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-11T19:30:36Z

@clnperez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-upi	0e560460ac80e649a40d13805f0733f0c9d028b0	link	false	`/test e2e-azure-upi`
ci/prow/okd-e2e-aws-upgrade	57245ea406350872b5e451e2e3e4644b0abe238a	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-aws-upgrade	57245ea406350872b5e451e2e3e4644b0abe238a	link	true	`/test e2e-aws-upgrade`
ci/prow/e2e-gcp-upgrade	57245ea406350872b5e451e2e3e4644b0abe238a	link	true	`/test e2e-gcp-upgrade`
ci/prow/e2e-metal-single-node-live-iso	`9a3bfb2`	link	false	`/test e2e-metal-single-node-live-iso`
ci/prow/e2e-gcp	`9a3bfb2`	link	false	`/test e2e-gcp`
ci/prow/e2e-azure-shared-vpc	`9a3bfb2`	link	false	`/test e2e-azure-shared-vpc`
ci/prow/okd-e2e-aws	`9a3bfb2`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-openstack-proxy	`9a3bfb2`	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-ibmcloud	`9a3bfb2`	link	false	`/test e2e-ibmcloud`
ci/prow/e2e-openstack-parallel	`9a3bfb2`	link	false	`/test e2e-openstack-parallel`
ci/prow/e2e-crc	`9a3bfb2`	link	false	`/test e2e-crc`
ci/prow/e2e-metal-ipi-ovn-ipv6	`9a3bfb2`	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-libvirt	`9a3bfb2`	link	false	`/test e2e-libvirt`
ci/prow/e2e-openstack	`9a3bfb2`	link	false	`/test e2e-openstack`
ci/prow/e2e-azurestack	`9a3bfb2`	link	false	`/test e2e-azurestack`
ci/prow/e2e-alibaba	`9a3bfb2`	link	false	`/test e2e-alibaba`
ci/prow/e2e-aws-disruptive	`9a3bfb2`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-gcp-upi-xpn	`9a3bfb2`	link	false	`/test e2e-gcp-upi-xpn`
ci/prow/e2e-azure-resourcegroup	`9a3bfb2`	link	false	`/test e2e-azure-resourcegroup`
ci/prow/e2e-gcp-shared-vpc	`9a3bfb2`	link	false	`/test e2e-gcp-shared-vpc`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-04-11T20:06:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

patrickdillon · 2022-04-11T20:12:29Z

/skip
/refresh

openshift-ci Bot requested review from jhixson74 and patrickdillon February 4, 2022 23:56

Prashanth684 reviewed Mar 21, 2022

View reviewed changes

Comment thread pkg/tfvars/powervs/powervs.go Outdated

clnperez force-pushed the new-tfvars-pkg branch 4 times, most recently from 84aafef to eebc7e5 Compare March 22, 2022 22:25

openshift-ci Bot assigned rna-afk Mar 23, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022

Prashanth684 reviewed Mar 23, 2022

View reviewed changes

Comment thread pkg/asset/cluster/tfvars.go Outdated

clnperez force-pushed the new-tfvars-pkg branch from 3740d01 to f3cb3ab Compare March 24, 2022 18:35

openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 24, 2022

clnperez force-pushed the new-tfvars-pkg branch 2 times, most recently from dc5d6f2 to c3d9b1e Compare March 24, 2022 18:50

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2022

clnperez force-pushed the new-tfvars-pkg branch from c3d9b1e to 0e56046 Compare March 24, 2022 21:55

clnperez force-pushed the new-tfvars-pkg branch from 0e56046 to 57245ea Compare March 25, 2022 19:43

clnperez mentioned this pull request Mar 29, 2022

Add IBM Power VS: tf data #5614

Merged

clnperez force-pushed the new-tfvars-pkg branch 2 times, most recently from a901ad7 to a6e8bab Compare April 6, 2022 15:14

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022

clnperez mentioned this pull request Apr 6, 2022

Power VS: Create Remaining TF Resources #5780

Merged

clnperez added 2 commits April 6, 2022 15:19

Add IBM Power VS: tfvars

9ddfba5

For more background on IPI on Power VS, refer to the enhancement proposal here: openshift/enhancements#736 Older discussions on some of the code here can be found in openshift#5224 Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

Power VS TFVars vendor

9a3bfb2

specifically, we need to pick up this commit: coreos/stream-metadata-go@89bd6bc Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>

clnperez force-pushed the new-tfvars-pkg branch from a6e8bab to 9a3bfb2 Compare April 6, 2022 20:19

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022

mjturek mentioned this pull request Apr 6, 2022

Power VS: Use bucket name from coreos stream rather than inferring it #5782

Merged

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022

openshift-merge-robot merged commit a8a0f7a into openshift:master Apr 11, 2022

Conversation

clnperez commented Feb 4, 2022

Uh oh!

Uh oh!

clnperez commented Mar 22, 2022

Uh oh!

clnperez commented Mar 23, 2022

Uh oh!

rna-afk commented Mar 23, 2022

Uh oh!

Uh oh!

clnperez commented Mar 24, 2022

Uh oh!

clnperez commented Mar 24, 2022

Uh oh!

rna-afk commented Mar 24, 2022

Uh oh!

clnperez commented Mar 24, 2022

Uh oh!

clnperez commented Mar 25, 2022

Uh oh!

clnperez commented Mar 29, 2022

Uh oh!

clnperez commented Mar 29, 2022

Uh oh!

clnperez commented Mar 29, 2022

Uh oh!

clnperez commented Apr 6, 2022

Uh oh!

rna-afk commented Apr 6, 2022

Uh oh!

clnperez commented Apr 6, 2022

Uh oh!

clnperez commented Apr 6, 2022

Uh oh!

rna-afk commented Apr 6, 2022

Uh oh!

clnperez commented Apr 7, 2022

Uh oh!

clnperez commented Apr 7, 2022

Uh oh!

patrickdillon commented Apr 11, 2022

Uh oh!

openshift-ci Bot commented Apr 11, 2022

Uh oh!

openshift-bot commented Apr 11, 2022

Uh oh!

openshift-bot commented Apr 11, 2022

Uh oh!

openshift-bot commented Apr 11, 2022

Uh oh!

openshift-bot commented Apr 11, 2022

Uh oh!

openshift-ci Bot commented Apr 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 11, 2022

Uh oh!

patrickdillon commented Apr 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci Bot commented Apr 11, 2022 •

edited

Loading