Skip to content

Conversation

@zhouhao3
Copy link
Contributor

Avoid the issue that ironic agent image cannot be downloaded due to network proxy.

See openshift/installer#5552 for details.

Signed-off-by: Zhou Hao [email protected]

@openshift-ci openshift-ci bot requested review from andfasano and hardys January 24, 2022 08:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

Hi @zhouhao3. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 24, 2022
@dtantsur
Copy link
Member

/ok-to-test

You'll need to attach a valid bug to merge this change at this point.

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2022
@zhouhao3 zhouhao3 force-pushed the add-proxy branch 2 times, most recently from 5d5ad23 to 100019b Compare January 25, 2022 03:18
Avoid the issue that ironic agent image cannot be downloaded due to network proxy.

Signed-off-by: Zhou Hao <[email protected]>
@zhouhao3
Copy link
Contributor Author

/cc @dtantsur @andfasano

@openshift-ci openshift-ci bot requested a review from dtantsur January 25, 2022 03:22
@zhouhao3
Copy link
Contributor Author

You'll need to attach a valid bug to merge this change at this point.

We are preparing BZ, I will update later.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@zhouhao3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@zhouhao3 zhouhao3 changed the title add proxy for ironic-agent.service Bug 2045927: Add proxy for ironic-agent.service Jan 26, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@zhouhao3: This pull request references Bugzilla bug 2045927, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2045927: Add proxy for ironic-agent.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhouhao3
Copy link
Contributor Author

@hardys @andfasano PTAL

@andfasano
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, zhouhao3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@openshift-merge-robot openshift-merge-robot merged commit 04a5cb3 into openshift:main Jan 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@zhouhao3: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2045927 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2045927: Add proxy for ironic-agent.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants