Add a way to override the interface used by bootstrap node #5554
Conversation
|
@bn222 Some CI jobs are failing (e.g. |
|
For other reviewers, this is an issue Balazs found on the ARM platform where it has a different interface name to ens4 (on x86 VMs). I think we can either provides an override interface as what this PR does or detect the platform to use the right interface name (assuming the interface name would persist across all ARM VMs). |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@zshi-redhat Thanks for adding the comment. I've run |
|
@bn222: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| if config.BootstrapProvisioningInterfaceOverride == "" { | ||
| templateData.ProvisioningInterface = "ens3" | ||
| } else { | ||
| templateData.ProvisioningInterface = config.BootstrapProvisioningInterfaceOverride |
There was a problem hiding this comment.
This nic is defined in the (installer created) bootstrap VM - so I'm not sure it's reasonable to expect the user to somehow know what the appropriate nic name is here?
I'm wondering why the VM nic name is different in your environment (which is ARM I believe) - is there some way we can make the nic name consistent between architectures instead, or else detect the required value based on the architecture?
|
/label platform/baremetal /cc @zaneb @sadasu @andfasano |
Do we know why the name is different? It seems weird that the nic number would increment if the VM definition is the same e.g we didn't add any nics? I'm wondering if there's some way to make the name consistent, and if that's not possible then IMO we should set the value inside the installer and not expose this implementation detail to the user. |
|
@hardys For me the nics are named different between arm/x86 because the bootstrap vm created by libvirt uses pci vs pcie controllers: More on nic naming in the rhel 8 network doc I have time to look into what it would take to discover the right nic name in the bootstrap container based on mac address (or something we don't have to hardcode), if you all agree and think it's feasible. |
|
/uncc |
|
Superseded by #5698 |
5 participants
Currently, the provision interface name is hardcoded to ens4. On my setup, this interface has a different name but there is no way to override this.
This patch adds a way to specify a different name.