Skip to content

Power VS IPI Support: types only#5292

Closed
clnperez wants to merge 1 commit intoopenshift:masterfrom
clnperez:upstream-types-only
Closed

Power VS IPI Support: types only#5292
clnperez wants to merge 1 commit intoopenshift:masterfrom
clnperez:upstream-types-only

Conversation

@clnperez
Copy link
Copy Markdown
Contributor

@clnperez clnperez commented Oct 12, 2021

Depends on #5270

Signed-off-by: Christy Norman christy@linux.vnet.ibm.com

@openshift-ci openshift-ci Bot requested review from e-tienne and rna-afk October 12, 2021 22:50
@clnperez clnperez changed the title Power VS Support: powervs types Power VS IPI Support: types only Oct 12, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign patrickdillon after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickdillon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 12, 2021
@clnperez clnperez force-pushed the upstream-types-only branch from cfb3760 to 8fd9b42 Compare October 12, 2021 22:58
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2021
@clnperez
Power VS Support: powervs types
34beec7 
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
@clnperez clnperez force-pushed the upstream-types-only branch from 8fd9b42 to 34beec7 Compare November 2, 2021 16:22
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 2, 2021

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • powervs-approvers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • powervs-reviewers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 4, 2021

@clnperez: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 1, 2021

@clnperez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-unit 34beec7 link true /test okd-unit
ci/prow/unit 34beec7 link true /test unit
ci/prow/e2e-ovirt 34beec7 link false /test e2e-ovirt
ci/prow/e2e-aws-workers-rhel7 34beec7 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 34beec7 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-single-node 34beec7 link false /test e2e-aws-single-node
ci/prow/okd-e2e-aws-upgrade 34beec7 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-openstack 34beec7 link false /test e2e-openstack
ci/prow/e2e-crc 34beec7 link false /test e2e-crc
ci/prow/openstack-manifests 34beec7 link true /test openstack-manifests
ci/prow/e2e-aws-upgrade 34beec7 link true /test e2e-aws-upgrade
ci/prow/e2e-aws 34beec7 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clnperez
Copy link
Copy Markdown
Contributor Author

clnperez commented Jan 7, 2022

this is very outdated. closing, and will create new ones when the installer team has bandwidth to review.

@clnperez clnperez closed this Jan 7, 2022
@clnperez clnperez mentioned this pull request Feb 4, 2022
Merged
clnperez added a commit to clnperez/installer that referenced this pull request Feb 26, 2022
@clnperez
Add IBM Power VS: types only
1604905 
For more background on IPI on Power VS, refer to the enhancement
proposal here: openshift/enhancements#736

Older discussions on some of the code here can be found in
openshift#5224.
An older unreviewed version of this PR can be found here:
openshift#5292

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-tienne e-tienne Awaiting requested review from e-tienne

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

No one assigned

Labels

do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@clnperez