Power VS IPI Support: TF Only#5270
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
do-not-merge/invalid-owners-file
clnperez
force-pushed
the
upstream-tf-only
branch
from
8f3465e to
8daf053
Compare
|
/verify-owners |
|
@mjturek should show up in the Openshift org soon. /retest-required |
clnperez
force-pushed
the
upstream-tf-only
branch
from
8daf053 to
ed84af3
Compare
There was a problem hiding this comment.
this should come from the regions that RHCOS is pushed to which is parsed from the stream metadata.similar to how AMI regions are done through the generate script.
But the question here is - are these the regions where the bootimage will be imported to ?
There was a problem hiding this comment.
ok, so we'll probably have to come up with a kind of hybrid approach then, or move this somewhere outside the rhcos purview, and combine what's there with the stream metadata. the regions at the top level are the Power VS regions -- not the IBM Cloud DC/COS regions the bootimage will be imported to.
There was a problem hiding this comment.
Also, the VPCRegions are tied to Regions here, so that we pick a close VPC Region to the Power VS Region. But again, we should probably create a different regions file since this doesn't always relate to the images. It does, though, when we're choosing which bucket to import from. It doesn't when we're creating the LBs.
There was a problem hiding this comment.
i think it makes sense that the user provides the PowerVS zones (us-east-1) and not care about the region where the image is located. so we have to have a mechanism to map these zones -> regions where the cos bucket is.
There was a problem hiding this comment.
can't we just have a single list for zones? instead of listing regions and zones under them ?
There was a problem hiding this comment.
We could, sure. Then we'd have to create a sub-list of Zones later using the name of the Region as a pattern. Sounds like we're re-thinking this file as a whole though so maybe not get too far into the weeds quite yet.
There was a problem hiding this comment.
a brief explanation of why this is needed would be nice.
clnperez
force-pushed
the
upstream-tf-only
branch
from
ed84af3 to
ec371ff
Compare
openshift-ci
Bot
removed
the
do-not-merge/invalid-owners-file
clnperez
force-pushed
the
upstream-tf-only
branch
from
ec371ff to
f364142
Compare
Enable Power VS(Virtual Servers) as a platform. PowerVS is an extension of IBMCloud which supports deploying ppc64le VMs. Details here: openshift/enhancements#736 The hostname for the VMs are set through afterburn which reads the metadata provided through the config drive which is the primary mechanism through which ignition and hostname are provided. (coreos/afterburn#592) Cross referencing some other PRs for completeness: openshift/installer#5270 openshift/installer#5224 (closed, WIP to split into multiple PRs) ova images for PowerVS are already generated today: coreos/coreos-assembler#2200 coreos/coreos-assembler#2361
openshift-ci
Bot
added
the
needs-rebase
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
clnperez
force-pushed
the
upstream-tf-only
branch
from
f364142 to
92ba212
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
@clnperez: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
needs-rebase
|
@clnperez: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
this is very outdated. closing, and will create new ones when the installer team has bandwidth to review. |
2 participants
For background see #5224
Instead of one massive PR, splitting the Power VS work into multiple PRs. This one contains the Terraform changes for supporting Power VS. There are currently three resources that aren't created via TF:
The two that are available aren't added here yet as it would make dev trickier. We plan to add these as soon as the functionality is available.
Everything is tested and is functional.