Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 11, 2018

The typo is from af6d904 (#293), which was itself fixing typos from 21ef0d4 (#284).

The typo is from af6d904 (fixing cmd and typo, 2018-09-20, openshift#293),
which was itself fixing typos from 21ef0d4 (adding details regarding
using of firewalld instead of iptables, 2018-09-19, openshift#284).
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2018
@rajatchopra
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajatchopra, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e0e77b2 into openshift:master Oct 12, 2018
@wking wking deleted the firewalld-cmd-typo branch October 12, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants