adding details regarding using firewalld instead of the iptables

[rlopez133]

Adding some documentation on how to use firewalld instead of the iptables command provided in the original document.

[abhinavdahiya]

/cc @crawford

[wking]

And can you also squash your typo fix in, so you have a single commit?

[wking]

Can you strip the trailing whitespace here (and in other places) to make Git happy:

$ git log -2 --check --oneline origin/pr/284
c66b9c9 fixed a small typo
2ce46b2 adding details regarding using firewalld instead of the iptables
Documentation/dev/libvirt-howto.md:88: trailing whitespace.
+If using `firewalld`, simply optain the name of the existing active zone which 
Documentation/dev/libvirt-howto.md:99: trailing whitespace.
+unless otherwise specified. 

[wking]

The example looks like a shell session, in which case, can you add a prompt and:

```console

for highlighting? That would be:

$ sudo firewall-cmd --get-active-zones
FedoraWorkstation
  interfaces: enp0s25 tun0

[wking]

You don't have any output here, and for shell examples without output we prefer no prompts and:

```sh

syntax highlighting (more on this in #27).

[wking]

Some more minor copy-edit suggestions ;)

[wking]

Can you backtick the literal --permanent?

[wking]

Maybe reword to something like:

Restart firewalld to remove your temporary changes:

or:

With the cluster removed, you no longer need to allow libvirt nodes to reach your libvirtd. Restart firewalld to remove your temporary changes:

[wking]

Maybe "a simple reload of firewalld" -> firewalld --reload.

[wking]

Ok, I think I'm done :p. This looks great, thanks :).

[rlopez133]

Adding all let me know if its good, squashed as well

[wking]

One nit, everything else looks great :).

[wking]

With console highlighting (which I think we want because you're showing output), you need a $ prompt here.

[rlopez133]

do you not want prompts on the others as well?

[wking]

do you not want prompts on the others as well?

Prompts belong in console blocks (to differentiate between commands and output), but not in sh blocks (because they're not part of the shell input). In this project, sh was more popular where we don't need to show output, so that's the pattern I'm trying to stick to (more on this in #27).

[crawford]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, rlopez133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [crawford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

Oops, looks like this should have been firewall-cmd --reload, based on the example below :/.