-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[release-4.6] Bug 1894310: baremetal: pin libvirt to 4.5.0 #4340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.6] Bug 1894310: baremetal: pin libvirt to 4.5.0 #4340
Conversation
The latest version of RHEL ships with libvirt 6.x, which are now in yum repositories used to build the CI containers. However, when running an installer built that's linked against it on an older RHEL host, the installer fails: ``` $ ocp/ostest/openshift-baremetal-install --dir ocp/ostest --log-level=debug create manifests ocp/ostest/openshift-baremetal-install: /lib64/libvirt.so.0: version ```LIBVIRT_5.2.0' not found (required by ocp/ostest/openshift-baremetal-install) [...snip...] ``` According to the [RHEL 8 ABI Guarantees](https://access.redhat.com/articles/rhel8-abi-compatibility), "an application is only guaranteed to run correctly if it executes in an environment that is as new as the environment it was built in or newer." Therefore, we must build openshift baremetal installer against the oldest version of the libvirt libraries we expect it to run against, which is 4.5.x. Long term, the libvirt team is looking at not linking to libvirt at compile time, but rather use `dlopen("libvirt.so")` at runtime, and then `dlsym("funcname")` to resolve functions at time they are first invoked.
|
@openshift-cherrypick-robot: Bugzilla bug 1894144 has been cloned as Bugzilla bug 1894310. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1894310, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@stbenjam: This pull request references Bugzilla bug 1894310, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold There's no need to spend the next several days retesting. Patch manager: please remove the hold when you're ready for this to make a z-stream. |
|
/retest |
|
This is now impacting CI e.g openshift/cluster-network-operator#850 |
|
/cc @sdodson |
|
Affects openshift/release#13120 as well |
|
/hold cancel |
|
/override ci/prow/e2e-azure-upi |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure-upi, ci/prow/e2e-vsphere-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-gcp-upi-xpn |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-gcp-upi-xpn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-azure-upi |
|
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade, ci/prow/e2e-azure-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1894310 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #4339
/assign stbenjam