update to allow openshift operator to run #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
Contributor
Author
|
Referenced pull merged. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
Is this API server even running? It could not talk to etcd last we checked? |
Contributor
Author
It can't, but the operator runs and we've updated to ensure that we don't create bad apiservices. Allowing this in ensures that our operator can't break things in the future. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the two openshift control plane operators.
/hold
Wait until openshift/cluster-openshift-apiserver-operator#30 merges to prevent registering apiservices that will never work. Doing that would prevent namespace cleanup controller from running.