Skip to content

operators: add cluster-openshift-apiserver-operator #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juanvallejo wants to merge 1 commit into from
Closed

operators: add cluster-openshift-apiserver-operator #298

juanvallejo wants to merge 1 commit into from

Conversation

@juanvallejo
Copy link

@juanvallejo juanvallejo commented Sep 20, 2018

Not sure if there's anything to generate.
Is there an operator registry somewhere / any files I may have missed when adding a new operator?

cc @deads2k @mfojtik @yifan-gu @abhinavdahiya

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2018
@juanvallejo juanvallejo force-pushed the add-cluster-openshift-apiserver-operator branch from 54235ad to 1f0b4a1 Compare September 20, 2018 21:50
@crawford
Copy link
Contributor

crawford commented Sep 21, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, juanvallejo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2018
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 21, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2018
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 21, 2018

Requires changes from https://github.com/coreos-inc/tectonic-operators/issues/464 so that we can actually check if we can bootstrap using this operator

abhinavdahiya
abhinavdahiya suggested changes Sep 21, 2018
View reviewed changes
...les/tectonic/resources/manifests/updater/operators/cluster-openshift-apiserver-operator.yaml Outdated
Copy link
Contributor

@abhinavdahiya abhinavdahiya Sep 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanvallejo can you change this to list of yaml objects

<yaml>
---
<yaml>

rather than List kind. both bootkube and ClusterVersionOperator will not support List kind. :|

Copy link
Author

@juanvallejo juanvallejo Sep 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will update

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 21, 2018

Also https://github.com/coreos-inc/tectonic-operators/pull/464#issuecomment-423590240

It might be private
@deads2k

apiservices are created for the openshift-apiserver by the cluster-openshift-apiserver-operator. Since the openshift-apiserver isn't required to have a viable control plane, there is no reason for it have any static resources created, so the operator can manage all of it.

@juanvallejo you will want to be sure that the service-ca operator is installed and active in the installer though.

@juanvallejo juanvallejo force-pushed the add-cluster-openshift-apiserver-operator branch from 1f0b4a1 to af69e1a Compare September 21, 2018 18:18
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 21, 2018

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2018
@juanvallejo
Copy link
Author

juanvallejo commented Sep 21, 2018

@abhinavdahiya Opened PR to add the openshift-service-ca-operator here: #306

@juanvallejo juanvallejo force-pushed the add-cluster-openshift-apiserver-operator branch from af69e1a to 625d321 Compare September 25, 2018 21:03
@juanvallejo
Copy link
Author

juanvallejo commented Sep 25, 2018

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2018

@juanvallejo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-smoke 625d321 link /test e2e-aws-smoke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 30, 2018

@juanvallejo: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2018
@wking wking mentioned this pull request Oct 5, 2018
Merged
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 8, 2018

/close

The operator is installed by CVO; #430 enables the operator.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2018

@abhinavdahiya: Closing this PR.

Details

In response to this:

/close

The operator is installed by CVO; #430 enables the operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juanvallejo @crawford @openshift-ci-robot @abhinavdahiya @openshift-bot