Bug 1820153: OpenStack: Allow destroying cluster without trunk ports #3395

mandre · 2020-04-02T11:52:11Z

When the cloud doesn't have support for trunk ports, we should not try
to delete them.

This is a manual backport of #3319 due to merge conflicts.

When the cloud doesn't have support for trunk ports, we should not try to delete them.

openshift-ci-robot · 2020-04-02T11:52:15Z

@mandre: This pull request references Bugzilla bug 1820153, which is invalid:

expected dependent Bugzilla bug 1814593 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1820153: OpenStack: Allow destroying cluster without trunk ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2020-04-02T13:11:38Z

/bugzilla refresh

openshift-ci-robot · 2020-04-02T13:11:47Z

@mandre: This pull request references Bugzilla bug 1820153, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1814593 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1814593 targets the "4.5.0" release, matching the expected (4.5.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2020-04-02T13:13:09Z

/test e2e-openstack

mandre · 2020-04-02T19:38:58Z

/test e2e-openstack

pierreprinetti · 2020-04-02T22:52:21Z

/approve
/lgtm

Thanks!

openshift-ci-robot · 2020-04-02T22:56:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/destroy/openstack/OWNERS~~ [pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-03T03:38:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T03:51:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T04:05:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T04:17:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T04:30:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T04:43:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T04:56:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T05:10:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T05:22:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T05:35:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T05:48:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T06:14:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T06:27:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T06:40:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T10:08:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T10:34:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T10:47:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T11:00:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T11:38:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T12:44:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T13:10:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T13:35:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T14:14:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T14:27:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T14:40:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T15:06:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T15:32:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T16:12:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T17:03:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T17:29:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T17:43:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T19:15:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T19:53:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T21:49:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T22:28:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T22:41:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T22:54:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-04-03T23:07:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-03T23:20:02Z

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`e542141`	link	`/test e2e-aws-scaleup-rhel7`
ci/prow/e2e-libvirt	`e542141`	link	`/test e2e-libvirt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-04-03T23:20:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-03T23:27:43Z

@mandre: All pull requests linked via external trackers have merged: openshift/installer#3395. Bugzilla bug 1820153 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1820153: OpenStack: Allow destroying cluster without trunk ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1820153: OpenStack: Allow destroying cluster without trunk ports

e542141

When the cloud doesn't have support for trunk ports, we should not try to delete them.

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 2, 2020

openshift-ci-robot requested review from fabianofranz and jstuever April 2, 2020 11:52

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 2, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 2, 2020

openshift-ci-robot assigned pierreprinetti Apr 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020

crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 3, 2020

openshift-merge-robot merged commit 39af1f7 into openshift:release-4.4 Apr 3, 2020

mandre mentioned this pull request Apr 9, 2020

[OpenStack] Destroy cluster gives eternal loop on "Deleting openstack trunks" #3433

Closed

Bug 1820153: OpenStack: Allow destroying cluster without trunk ports #3395

Bug 1820153: OpenStack: Allow destroying cluster without trunk ports #3395

Uh oh!

Conversation

mandre commented Apr 2, 2020

Uh oh!

openshift-ci-robot commented Apr 2, 2020

Uh oh!

mandre commented Apr 2, 2020

Uh oh!

openshift-ci-robot commented Apr 2, 2020

Uh oh!

mandre commented Apr 2, 2020

Uh oh!

mandre commented Apr 2, 2020

Uh oh!

pierreprinetti commented Apr 2, 2020

Uh oh!

openshift-ci-robot commented Apr 2, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!

openshift-bot commented Apr 3, 2020

Uh oh!