Skip to content

Bug 1814593: OpenStack: Allow destroying cluster without trunk ports #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 24, 2020
Merged

Bug 1814593: OpenStack: Allow destroying cluster without trunk ports #3319

openshift-merge-robot merged 1 commit into from
Mar 24, 2020

Conversation

@mandre
Copy link
Member

@mandre mandre commented Mar 19, 2020

When the cloud doesn't have support for trunk ports, we should not try
to delete them.

@mandre
Bug 1814593: OpenStack: Allow destroying cluster without trunk ports
54fad47 
When the cloud doesn't have support for trunk ports, we should not try
to delete them.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2020

@mandre: This pull request references Bugzilla bug 1814593, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1814593: OpenStack: Allow destroying cluster without trunk ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 19, 2020
@mandre
Copy link
Member Author

mandre commented Mar 19, 2020

/uncc @jhixson74 @jstuever
/cc @Fedosin @pierreprinetti

@openshift-ci-robot openshift-ci-robot requested review from Fedosin and pierreprinetti and removed request for jhixson74 and jstuever March 19, 2020 16:00
@mandre
Copy link
Member Author

mandre commented Mar 19, 2020

/label platform/openstack

@pierreprinetti
Copy link
Member

pierreprinetti commented Mar 19, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fedosin
Copy link
Contributor

Fedosin commented Mar 19, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@pierreprinetti
Copy link
Member

pierreprinetti commented Mar 20, 2020

/retest

1 similar comment
@pierreprinetti
Copy link
Member

pierreprinetti commented Mar 23, 2020

/retest

@pierreprinetti
Copy link
Member

pierreprinetti commented Mar 23, 2020

/retest
I am not sure what is going on with the osp test

@pierreprinetti
Copy link
Member

pierreprinetti commented Mar 24, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d9bcea3 into openshift:master Mar 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 24, 2020

@mandre: All pull requests linked via external trackers have merged. Bugzilla bug 1814593 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1814593: OpenStack: Allow destroying cluster without trunk ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 24, 2020

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 54fad47 link /test e2e-ovirt
ci/prow/e2e-libvirt 54fad47 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member Author

mandre commented Apr 1, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 1, 2020

@mandre: #3319 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/destroy/openstack/openstack.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/destroy/openstack/openstack.go
CONFLICT (content): Merge conflict in pkg/destroy/openstack/openstack.go
Patch failed at 0001 Bug 1814593: OpenStack: Allow destroying cluster without trunk ports
Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre mentioned this pull request Apr 2, 2020
Merged
@mandre mandre deleted the openstack-delete-trunks branch April 15, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

1 more reviewer

@Fedosin Fedosin Fedosin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mandre @openshift-ci-robot @pierreprinetti @Fedosin @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot