pass the manifests-dir param to CCO render #3381
Conversation
|
This builds on the work in openshift/cloud-credential-operator#171 |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/test e2e-aws |
|
/retest |
There was a problem hiding this comment.
mannifests -> manifests
There was a problem hiding this comment.
nice! where in the failed CI artifacts could i have seen that message?
There was a problem hiding this comment.
This allows someone installing OpenShift to slip in a ConfigMap that keeps cloud-credential-operator from ever starting up. The process would look like: openshift-install create manifests create YAML for CCO Configmap for namespace/name: openshift-cloud-credential-operator/cloud-credential-operator-config openshift-install create cluster When the CCO render command sees the ConfigMap indicating that it should be disabled, it will not render the bootstrap Pod manifest, and the ConfigMap will make it into the cluster so the in-cluster CCO will also not attempt to run.
|
@joelddiaz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
4 participants
This allows someone installing OpenShift to slip in a ConfigMap that keeps cloud-credential-operator from ever starting up.
The process would look like:
openshift-install create manifests
create YAML for CCO Configmap for namespace/name: openshift-cloud-credential-operator/cloud-credential-operator-config
openshift-install create cluster
When the CCO render command sees the ConfigMap indicating that it should be disabled, it will not render the bootstrap Pod manifest, and the ConfigMap will make it into the cluster so the in-cluster CCO will also not attempt to run.