Skip to content

Conversation

@joelddiaz
Copy link
Contributor

allow explicitly setting a --manifests-dir where the render process should look for the CCO configmap to determin whether or not to enable CCO during bootstrap.

allow explicitly setting a --manifests-dir where the render process should look for the CCO configmap to determin whether or not to enable CCO during bootstrap.
@joelddiaz joelddiaz requested a review from dgoodwin March 30, 2020 15:52
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@dgoodwin
Copy link
Contributor

Can you clarify why we'd add this option and modify the installer, vs just assuming /asset/manifests?

@joelddiaz
Copy link
Contributor Author

@dgoodwin
Copy link
Contributor

/lgtm

SOLD!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 53fdb37 into openshift:master Mar 30, 2020
@joelddiaz joelddiaz deleted the disable-cco-round-2 branch June 16, 2020 17:54
ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
add explicit --manifests-dir for render bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants