Skip to content

Bug 1798805: baremetal: Fix bootstrap local DNS for IPv6 #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 14, 2020
Merged

Bug 1798805: baremetal: Fix bootstrap local DNS for IPv6 #3092

openshift-merge-robot merged 1 commit into from
Feb 14, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 11, 2020

This is an automated cherry-pick of #2982

/assign russellb

@russellb
baremetal: Fix bootstrap local DNS for IPv6
c0f5688 
This was previously done with an option to dhclient, but this doesn't
work when doing DHCPv6.  Switch to a script run by NetworkManager to do
the same thing.

This matches the same approach moved to by the MCO in this PR:

openshift/machine-config-operator#1396
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 11, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1801436, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1801436 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2020
@russellb russellb changed the title [release-4.3] Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6 [release-4.3] Bug 1801873: baremetal: Fix bootstrap local DNS for IPv6 Feb 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1801873, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.3] Bug 1801873: baremetal: Fix bootstrap local DNS for IPv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 11, 2020
@celebdor
Copy link
Contributor

celebdor commented Feb 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@sdodson
Copy link
Member

sdodson commented Feb 13, 2020

/retitle Bug 1798805: baremetal: Fix bootstrap local DNS for IPv6

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1801873: baremetal: Fix bootstrap local DNS for IPv6 Bug 1798805: baremetal: Fix bootstrap local DNS for IPv6 Feb 13, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1798805, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "---" instead
  • expected Bugzilla bug 1798805 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1798805: baremetal: Fix bootstrap local DNS for IPv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 13, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@sdodson: This pull request references Bugzilla bug 1798805, which is invalid:

  • expected Bugzilla bug 1798805 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 13, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@sdodson: This pull request references Bugzilla bug 1798805, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 13, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 13, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e20995c into openshift:release-4.3 Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1798805 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1798805: baremetal: Fix bootstrap local DNS for IPv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@russellb russellb

@celebdor celebdor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @celebdor @sdodson @openshift-bot @mfojtik @russellb @openshift-merge-robot