Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6 #2982

russellb · 2020-01-24T18:43:40Z

This was previously done with an option to dhclient, but this doesn't
work when doing DHCPv6. Switch to a script run by NetworkManager to do
the same thing.

This matches the same approach moved to by the MCO in this PR:

openshift/machine-config-operator#1396

This was previously done with an option to dhclient, but this doesn't work when doing DHCPv6. Switch to a script run by NetworkManager to do the same thing. This matches the same approach moved to by the MCO in this PR: openshift/machine-config-operator#1396

russellb · 2020-01-24T18:44:13Z

/cc @hardys
/cc @celebdor
/cc @stbenjam

This was previously done with an option to dhclient, but this doesn't work when doing DHCPv6. Switch to a script run by NetworkManager to do the same thing. This matches the same approach moved to by the MCO in this PR: openshift/machine-config-operator#1396

stbenjam · 2020-01-24T19:16:25Z

/label platform/baremetal

metal3ci · 2020-01-24T20:31:44Z

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1458/

hardys · 2020-01-27T10:28:20Z

/retest

russellb · 2020-01-30T14:47:32Z

/retest

hardys · 2020-01-30T15:46:09Z

/lgtm

russellb · 2020-01-30T16:17:48Z

@fabianofranz can you take a look at this one?

celebdor · 2020-01-30T16:33:02Z

/approve

celebdor

Great. This will take care of any other NM dispatcher script as well

sdodson · 2020-02-10T16:19:07Z

/approve

openshift-ci-robot · 2020-02-10T16:19:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-02-10T16:29:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-10T16:43:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

abhinavdahiya · 2020-02-10T17:12:22Z

data/data/bootstrap/baremetal/files/etc/NetworkManager/dispatcher.d/30-local-dns-prepender

@@ -0,0 +1,20 @@
+#!/bin/bash


how is this file different from the mco PR https://github.com/openshift/machine-config-operator/pull/1396/files# ?? I don't see any such file in that PR.

"30-resolv-prepender" - that one adds the DNS VIP to resolv.conf. On the bootstrap host we just need localhost added, which is what this PR does.

abhinavdahiya · 2020-02-10T17:13:00Z

pkg/asset/ignition/bootstrap/bootstrap.go

 	var mode int
 	appendToFile := false
-	if path.Base(path.Dir(uri)) == "bin" {
+	if parentDir == "bin" || parentDir == "dispatcher.d" {


Also it would be nice if you can include why these files need to have same permissions as bin files?

Yeah, a comment would probably be nice. It's a directory of scripts executed by NetworkManager.

openshift-bot · 2020-02-10T18:39:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-10T21:01:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-10T21:15:44Z

@russellb: This pull request references Bugzilla bug 1801436, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

russellb · 2020-02-10T21:15:49Z

/bugzilla refresh

openshift-ci-robot · 2020-02-10T21:15:51Z

@russellb: This pull request references Bugzilla bug 1801436, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

russellb · 2020-02-10T21:16:36Z

/bugzilla refresh

openshift-ci-robot · 2020-02-10T21:16:42Z

@russellb: This pull request references Bugzilla bug 1801436, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-02-10T21:52:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-10T22:13:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-10T22:39:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-11T00:36:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-11T02:07:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-11T02:20:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-11T02:33:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-11T02:46:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-11T03:24:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-11T03:37:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-11T03:45:42Z

@russellb: All pull requests linked via external trackers have merged. Bugzilla bug 1801436 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-11T04:50:53Z

@russellb: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`80c458b`	link	`/test e2e-aws-scaleup-rhel7`
ci/prow/e2e-libvirt	`80c458b`	link	`/test e2e-libvirt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

russellb · 2020-02-11T16:08:48Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2020-02-11T16:09:08Z

@russellb: new pull request created: #3092

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2020

openshift-ci-robot requested review from celebdor, hardys and stbenjam January 24, 2020 18:44

openshift-ci-robot requested review from markmc and patrickdillon January 24, 2020 18:46

openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Jan 24, 2020

openshift-ci-robot assigned hardys Jan 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020

celebdor approved these changes Jan 30, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020

abhinavdahiya reviewed Feb 10, 2020

View reviewed changes

russellb changed the title ~~baremetal: Fix bootstrap local DNS for IPv6~~ Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6 Feb 10, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 10, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 10, 2020

openshift-merge-robot merged commit 5c21552 into openshift:master Feb 11, 2020

openshift-cherrypick-robot mentioned this pull request Feb 11, 2020

Bug 1798805: baremetal: Fix bootstrap local DNS for IPv6 #3092

Merged

Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6 #2982

Bug 1801436: baremetal: Fix bootstrap local DNS for IPv6 #2982

Uh oh!

Conversation

russellb commented Jan 24, 2020

Uh oh!

russellb commented Jan 24, 2020

Uh oh!

stbenjam commented Jan 24, 2020

Uh oh!

metal3ci commented Jan 24, 2020

Uh oh!

hardys commented Jan 27, 2020

Uh oh!

russellb commented Jan 30, 2020

Uh oh!

hardys commented Jan 30, 2020

Uh oh!

russellb commented Jan 30, 2020

Uh oh!

celebdor commented Jan 30, 2020

Uh oh!

celebdor left a comment

Choose a reason for hiding this comment

Uh oh!

sdodson commented Feb 10, 2020

Uh oh!

openshift-ci-robot commented Feb 10, 2020

Uh oh!

openshift-bot commented Feb 10, 2020

Uh oh!

openshift-bot commented Feb 10, 2020

Uh oh!

abhinavdahiya Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

russellb Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

abhinavdahiya Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

russellb Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Feb 10, 2020

Uh oh!

openshift-bot commented Feb 10, 2020

Uh oh!

openshift-ci-robot commented Feb 10, 2020

Uh oh!

russellb commented Feb 10, 2020

Uh oh!

openshift-ci-robot commented Feb 10, 2020

Uh oh!

russellb commented Feb 10, 2020

Uh oh!

openshift-ci-robot commented Feb 10, 2020

Uh oh!

openshift-bot commented Feb 10, 2020

Uh oh!

openshift-bot commented Feb 10, 2020

Uh oh!

openshift-bot commented Feb 10, 2020

Uh oh!

openshift-bot commented Feb 11, 2020

Uh oh!

openshift-bot commented Feb 11, 2020

Uh oh!

openshift-bot commented Feb 11, 2020

Uh oh!

openshift-bot commented Feb 11, 2020

Uh oh!

openshift-bot commented Feb 11, 2020

Uh oh!

openshift-bot commented Feb 11, 2020

Uh oh!

openshift-bot commented Feb 11, 2020

Uh oh!

openshift-ci-robot commented Feb 11, 2020