Skip to content

Documentation/dev/audiences: Replace 'make' reference with Bazel #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 1 commit into from
Closed

Documentation/dev/audiences: Replace 'make' reference with Bazel #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Documentation/dev/audiences.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ We should strive to _never require_ end-users to use or install `make`, `npm`, e

## Developer experience

The developer workflow is reflective of how often clusters will be created and destroyed. This project makes heavy use of `make` to make these repetitive actions easier.
The developer workflow is reflective of how often clusters will be created and destroyed. This project makes heavy use of [Bazel][] to make these repetitive actions easier.
Copy link
Contributor

@squat squat Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference to make has nothing to do with building the project but rather the developer workflow we used to have for quickly creating and destroying clusters using make apply and make destroy. It is unrelated to Bazel as we never use bazel to automate building or destroying clusters. We should remove this line wholesale or replace with one describing the new dev workflow.

Copy link
Member Author

@wking wking Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this line wholesale or replace with one describing the new dev workflow.

Sounds good to me. I'll leave that to someone who actually knows what the new dev workflow is ;). Should I leave this PR open as a reminder? Or should I close it (with or without filing a placeholder issue)?

Copy link
Contributor

@squat squat Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for understanding. Please close and file an issue 👍


It is expected that developers have a working knowledge of Terraform, including how to configure/use a `.terraformrc` and things of that nature.

[Bazel]: https://bazel.build/