Documentation/dev/audiences: Replace 'make' reference with Bazel #30
Conversation
Catching up with d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137), which removed the root Makefile.
|
Can one of the admins verify this patch? |
|
Hi @wking. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
needs-ok-to-test
| ## Developer experience | ||
|
|
||
| The developer workflow is reflective of how often clusters will be created and destroyed. This project makes heavy use of `make` to make these repetitive actions easier. | ||
| The developer workflow is reflective of how often clusters will be created and destroyed. This project makes heavy use of [Bazel][] to make these repetitive actions easier. |
There was a problem hiding this comment.
This reference to make has nothing to do with building the project but rather the developer workflow we used to have for quickly creating and destroying clusters using make apply and make destroy. It is unrelated to Bazel as we never use bazel to automate building or destroying clusters. We should remove this line wholesale or replace with one describing the new dev workflow.
There was a problem hiding this comment.
We should remove this line wholesale or replace with one describing the new dev workflow.
Sounds good to me. I'll leave that to someone who actually knows what the new dev workflow is ;). Should I leave this PR open as a reminder? Or should I close it (with or without filing a placeholder issue)?
There was a problem hiding this comment.
Thanks for understanding. Please close and file an issue 👍
Add bmh as a relatedobject in the clusteroperator
Currently TFVars only generates powervs_region. This patch introduces a map between regions used by the PowerVS provider with regions used by the VPC provider and sets powervs_vpc_region using it. Additionally, removes powervs_zone and powervs_vpc_zone as they are not required currently.
Currently TFVars only generates powervs_region. This patch introduces a map between regions used by the PowerVS provider with regions used by the VPC provider and sets powervs_vpc_region using it. Additionally, removes powervs_zone and powervs_vpc_zone as they are not required currently.
4 participants
Catching up with d61abd4 (coreos/tectonic-installer#3137), which removed the root
Makefile.