Skip to content

WIP [FCOS] vSphere: update UPI files to tf 1.12 #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdodson merged 3 commits into from
Jan 21, 2020
Merged

WIP [FCOS] vSphere: update UPI files to tf 1.12 #2953

sdodson merged 3 commits into from
Jan 21, 2020

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jan 20, 2020 •
edited
Loading

See #2952 (comment)

Current issues:

  • [x] Update code to tf 0.12
  • [ ] Fix No instance found for the given address! for terraform state show 'module.bootstrap.external.ip_address' call
  • Use terraform 0.11
  • Find out why worker.ign and master.ign don't have external API endpoint set

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign crawford
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs changed the title [FCOS] vSphere: update UPI files to tf 1.12 WIP [FCOS] vSphere: update UPI files to tf 1.12 Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2020
@vrutkovs vrutkovs force-pushed the fcos-jan20-rebase-vsphere branch 2 times, most recently from 7b4f161 to 0af9cde Compare January 20, 2020 23:33
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 20, 2020

/cc @DanyC97

This seem to be very similar to #2057, mind having a look?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2020

@vrutkovs: GitHub didn't allow me to request PR reviews from the following users: DanyC97.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @DanyC97

This seem to be very similar to #2057, mind having a look?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs force-pushed the fcos-jan20-rebase-vsphere branch 2 times, most recently from 46f438d to ed741ec Compare January 21, 2020 00:05
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 21, 2020

/retest

1 similar comment
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 21, 2020

/retest

@vrutkovs vrutkovs force-pushed the fcos-jan20-rebase-vsphere branch 4 times, most recently from 606092c to 593836d Compare January 21, 2020 11:12
vsphere: require terraform-plugin-ignition v2.0.0
80d1fbe 
Use LorbusChris fork and rename binary to match terraform 0.12 expectations
@vrutkovs vrutkovs force-pushed the fcos-jan20-rebase-vsphere branch 5 times, most recently from e4a5920 to 32755b7 Compare January 21, 2020 13:11
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2020
@vrutkovs vrutkovs force-pushed the fcos-jan20-rebase-vsphere branch from 32755b7 to de1c4b1 Compare January 21, 2020 13:40
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2020
@vrutkovs vrutkovs force-pushed the fcos-jan20-rebase-vsphere branch from de1c4b1 to 361c90f Compare January 21, 2020 14:51
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 21, 2020

/retest

@sdodson sdodson merged commit 3e300ce into openshift:fcos Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2020

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 361c90f link /test e2e-vsphere
ci/prow/e2e-aws 361c90f link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@DanyC97
Copy link
Contributor

DanyC97 commented Jan 22, 2020

/cc @DanyC97

This seem to be very similar to #2057, mind having a look?

hi @vrutkovs as per our conv, i'll try to crack on with this as soon as i get my dev env setup. will keep you up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jstuever jstuever Awaiting requested review from jstuever

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vrutkovs @openshift-ci-robot @DanyC97 @sdodson