Add and vendor VSphere Terraform provider. #2897

patrickdillon · 2020-01-10T02:05:18Z

Vendored dependencies are a result of adding constraint to Gopkg.toml and running dep ensure.

cc @jcpowermac @jstuever

jstuever · 2020-01-10T17:10:27Z

/lgtm

patrickdillon · 2020-01-10T17:29:10Z

/retest

patrickdillon · 2020-01-10T19:38:01Z

/retest

jstuever · 2020-01-10T19:55:03Z

/assign @wking

patrickdillon · 2020-01-10T20:12:22Z

I am baffled why shellcheck is failing for this PR but not #2893 when both vendor the same file in question...

[padillon@thinkpad installer]$ diff <(curl -s https://raw.githubusercontent.com/openshift/installer/09ec4d2adfea366e60014f2e284c685c65315bf4/pkg/terraform/exec/plugins/vendor/github.com/vmware/govmomi/scripts/license.sh) <(curl -s https://raw.githubusercontent.com/openshift/installer/54f5b4b45375d65c3db7077aaa30f1209758fe7a/vendor/github.com/vmware/govmomi/scripts/license.sh)
[padillon@thinkpad installer]$

patrickdillon · 2020-01-11T23:33:21Z

/retest

patrickdillon · 2020-01-13T13:55:49Z

shellcheck issue resolves. thanks joe!

sdodson · 2020-01-13T14:05:24Z

/approve

openshift-ci-robot · 2020-01-13T14:06:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-13T14:17:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T15:06:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T15:39:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T15:52:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T16:57:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T17:11:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T17:23:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T18:28:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T18:54:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-13T19:07:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-01-13T19:09:07Z

merge conflict, so stop the hot looping
/lgtm cancel

sdodson · 2020-01-14T02:35:14Z

/refresh

patrickdillon · 2020-01-14T13:25:24Z

/retest

openshift-bot · 2020-01-14T13:31:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

patrickdillon · 2020-01-14T13:34:00Z

/hold

Running dep ensure against master branch with no changes removes this code.

An override for govmomi is required because terraform-provider-vsphere has not been updated to use 0399353f7859c4775827e454b2cc4f57956dd7ac from govmomi. Therfore, if you use the newest version it will not build.

patrickdillon · 2020-01-14T21:36:04Z

/hold cancel

The vSphere provider has a transitive dependency on govmomi, which I added, because it has not been updated to include this PR vmware/govmomi@0399353#diff-4c906832aa0dba4d3e0e7075107581f3

Also, this PR removes an unused oVirt dependency which was left in master.

jcpowermac · 2020-01-15T14:01:53Z

/lgtm

openshift-bot · 2020-01-15T14:05:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-15T14:18:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-15T14:43:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-15T14:56:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-15T15:09:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-15T15:22:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mtnbikenc · 2020-01-15T15:25:34Z

/hold
Tests are churning.

openshift-ci-robot · 2020-01-15T15:42:24Z

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	`e21e99f`	link	`/test e2e-openstack`
ci/prow/e2e-libvirt	`e21e99f`	link	`/test e2e-libvirt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

patrickdillon · 2020-01-15T18:00:55Z

/hold cancel
/skip
I think churn is resolved...

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 10, 2020

openshift-ci-robot requested review from fabianofranz and jhixson74 January 10, 2020 02:05

openshift-ci-robot assigned jstuever Jan 10, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020

jstuever removed their assignment Jan 10, 2020

openshift-ci-robot assigned wking Jan 10, 2020

jcpowermac mentioned this pull request Jan 10, 2020

Add terraform vendor path to shellcheck #2901

Merged

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2020

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020

patrickdillon force-pushed the vsphere-provider branch from 055a1ca to fa0142f Compare January 14, 2020 21:26

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 14, 2020

patrickdillon added 2 commits January 14, 2020 16:30

Remove unused oVirt code from terraform plugins.

171e20b

Running dep ensure against master branch with no changes removes this code.

Add and vendor Terraform-vSphere plugin.

e21e99f

An override for govmomi is required because terraform-provider-vsphere has not been updated to use 0399353f7859c4775827e454b2cc4f57956dd7ac from govmomi. Therfore, if you use the newest version it will not build.

patrickdillon force-pushed the vsphere-provider branch from fa0142f to e21e99f Compare January 14, 2020 21:30

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020

openshift-ci-robot assigned jcpowermac Jan 15, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2020

openshift-merge-robot merged commit a035040 into openshift:master Jan 15, 2020

Add and vendor VSphere Terraform provider. #2897

Add and vendor VSphere Terraform provider. #2897

Uh oh!

Conversation

patrickdillon commented Jan 10, 2020

Uh oh!

jstuever commented Jan 10, 2020

Uh oh!

patrickdillon commented Jan 10, 2020

Uh oh!

patrickdillon commented Jan 10, 2020

Uh oh!

jstuever commented Jan 10, 2020

Uh oh!

patrickdillon commented Jan 10, 2020

Uh oh!

patrickdillon commented Jan 11, 2020

Uh oh!

patrickdillon commented Jan 13, 2020

Uh oh!

sdodson commented Jan 13, 2020

Uh oh!

openshift-ci-robot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

openshift-bot commented Jan 13, 2020

Uh oh!

sdodson commented Jan 13, 2020

Uh oh!

sdodson commented Jan 14, 2020

Uh oh!

patrickdillon commented Jan 14, 2020

Uh oh!

openshift-bot commented Jan 14, 2020

Uh oh!

patrickdillon commented Jan 14, 2020

Uh oh!

patrickdillon commented Jan 14, 2020

Uh oh!

jcpowermac commented Jan 15, 2020

Uh oh!

openshift-bot commented Jan 15, 2020

Uh oh!

openshift-bot commented Jan 15, 2020

Uh oh!

openshift-bot commented Jan 15, 2020

Uh oh!

openshift-bot commented Jan 15, 2020

Uh oh!

openshift-bot commented Jan 15, 2020

Uh oh!

openshift-bot commented Jan 15, 2020

Uh oh!

mtnbikenc commented Jan 15, 2020

Uh oh!

openshift-ci-robot commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickdillon commented Jan 15, 2020

Uh oh!

Reviewers

Assignees

Labels

openshift-ci-robot commented Jan 15, 2020 •

edited

Loading