Add vSphere IPI destroy #2893

jcpowermac · 2020-01-08T21:37:08Z

Modify clustermetadata to include VSphere
Add additional fields for auth to vsphere Metadata struct
that is required for accessing vSphere vCenter
to destroy cluster infrastructure objects
vSphere Destroy
- Create clients for both soap and rest
- Finds the vCenter objects attached to the Tag
- Retieve the ManagedObjects for both Folder and VirtualMachine
- Confirm that exactly one Folder is available
- Remove VirtualMachines that are a child of Folder
- Remove Folder if empty

jcpowermac · 2020-01-08T21:37:52Z

Need to update Gopkg (will do in another commit)

jcpowermac · 2020-01-08T22:01:49Z

@patrickdillon
@mtnbikenc
when you have a moment if I can get an initial review.

jcpowermac · 2020-01-08T22:16:40Z

Looks like:
https://github.com/openshift/machine-api-operator/blob/master/go.mod#L28
is using govmomi version v0.21.0 we might want to use that version as well.

jcpowermac · 2020-01-16T00:06:41Z

pkg/types/vsphere/client.go

@jstuever ^

jcpowermac · 2020-01-16T00:22:39Z

/retest

patrickdillon

Currently there is no output when you run destroy at the standard log level. I left a couple of suggestions of where I definitely think we should switch debug to info but I think that is a minimum and we could be more verbose.

patrickdillon · 2020-01-17T21:30:04Z

pkg/destroy/vsphere/vsphere.go

nit: regroup these internal imports to:
stdlib

external

internal

patrickdillon · 2020-01-20T15:54:50Z

pkg/destroy/vsphere/vsphere.go

This output should be shown at the default log-level so virtualMachineLogger.Debug -> virtualMachineLogger.Info

patrickdillon · 2020-01-20T15:55:28Z

pkg/destroy/vsphere/vsphere.go

.Debug -> .Info

patrickdillon · 2020-01-20T16:02:33Z

pkg/destroy/vsphere/vsphere.go

This comment can be removed (or updated as we are using InfraID)

- Modify clustermetadata to include VSphere - Add additional fields for auth to vsphere Metadata struct that is required for accessing vSphere vCenter to destroy cluster infrastructure objects - vSphere Destroy - Create clients for both soap and rest - Finds the vCenter objects attached to the Tag - Retieve the ManagedObjects for both Folder and VirtualMachine - Confirm that exactly one Folder is available - Remove VirtualMachines that are a child of Folder - Remove Folder if empty vsphere missing metadata - Modified `pkg/asset/cluster/metadata.go` to include the vsphere case for creating the metadata asset - Created vsphere metadata function to populate metadata struct with auth from install config. Create vsphere `client.go` that contains a single function to create vSphere SOAP and REST clients that will be used for at least destroy and gather bootstrap

patrickdillon · 2020-01-20T20:56:04Z

Logging changes look good to me.
Before change there was no output:

$ ./openshift-install create cluster --dir vsphere
$

Now deleted resources are output:

$ ./openshift-install destroy cluster --dir vsphere
INFO Destroyed                                     VirtualMachine=test-cluster-v2mww-master-1
INFO Destroyed                                     VirtualMachine=test-cluster-v2mww-master-0
INFO Destroyed                                     VirtualMachine=test-cluster-v2mww-master-2
INFO Destroyed                                     VirtualMachine=test-cluster-v2mww-bootstrap
INFO Destroyed                                     Folder=test-cluster-v2mww
$

For reference, here is log with --log-level debug

$ ./openshift-install destroy cluster --dir vsphere --log-level debug
DEBUG OpenShift Installer unreleased-master-2383-gaade1eb75561332885c102eac3ebd2af3c6e8b20 
DEBUG Built from commit aade1eb75561332885c102eac3ebd2af3c6e8b20 
DEBUG find attached objects on tag                 
DEBUG find Folder objects                          
DEBUG find VirtualMachine objects                  
DEBUG delete VirtualMachines                       
DEBUG Powered off                                   VirtualMachine=test-cluster-sp8d9-master-0
INFO Destroyed                                     VirtualMachine=test-cluster-sp8d9-master-0
DEBUG Powered off                                   VirtualMachine=test-cluster-sp8d9-master-2
INFO Destroyed                                     VirtualMachine=test-cluster-sp8d9-master-2
DEBUG Powered off                                   VirtualMachine=test-cluster-sp8d9-master-1
INFO Destroyed                                     VirtualMachine=test-cluster-sp8d9-master-1
DEBUG Powered off                                   VirtualMachine=test-cluster-sp8d9-bootstrap
INFO Destroyed                                     VirtualMachine=test-cluster-sp8d9-bootstrap
DEBUG find Folder objects                          
DEBUG delete Folder                                
INFO Destroyed                                     Folder=test-cluster-sp8d9
DEBUG Purging asset "Terraform Variables" from disk 
DEBUG Purging asset "Kubeconfig Admin Client" from disk 
DEBUG Purging asset "Kubeadmin Password" from disk 
DEBUG Purging asset "Certificate (journal-gatewayd)" from disk 
DEBUG Purging asset "Metadata" from disk           
DEBUG Purging asset "Cluster" from disk            
$

/lgtm

jcpowermac · 2020-01-20T21:00:01Z

/assign @sdodson

sdodson · 2020-01-20T21:15:14Z

/approve

sdodson · 2020-01-20T21:16:39Z

/approve

openshift-ci-robot · 2020-01-20T21:17:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-21T13:25:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jcpowermac · 2020-01-21T14:15:53Z

/hold
e2e-aws-upgrade broken

jcpowermac · 2020-01-22T18:27:16Z

/hold cancel

jcpowermac · 2020-01-22T18:27:23Z

/retest

openshift-bot · 2020-01-22T18:34:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T19:51:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T20:43:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T21:22:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T22:53:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T00:25:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T00:50:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T02:47:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T03:00:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T03:28:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T03:53:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T04:05:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T04:57:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T05:10:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T05:24:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T05:36:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T06:02:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T06:28:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T08:51:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T10:48:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T11:01:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-23T12:44:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2020

openshift-ci-robot requested review from jhixson74 and patrickdillon January 8, 2020 21:38

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2020

patrickdillon mentioned this pull request Jan 10, 2020

Add and vendor VSphere Terraform provider. #2897

Merged

jcpowermac force-pushed the CORS-1327 branch 2 times, most recently from fdd7ce2 to 1c4de9a Compare January 16, 2020 00:01

jcpowermac commented Jan 16, 2020

View reviewed changes

pkg/types/vsphere/client.go Outdated

Copy link

Contributor Author

jcpowermac Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstuever ^

patrickdillon reacted with thumbs up emoji

jcpowermac changed the title ~~[wip] Add vSphere IPI destroy~~ Add vSphere IPI destroy Jan 16, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020

jcpowermac force-pushed the CORS-1327 branch from 1c4de9a to b810467 Compare January 16, 2020 00:10

patrickdillon reviewed Jan 20, 2020

View reviewed changes

jcpowermac added 2 commits January 20, 2020 15:28

required govmomi deps

12add29

jcpowermac force-pushed the CORS-1327 branch from b810467 to 12add29 Compare January 20, 2020 20:28

openshift-ci-robot assigned patrickdillon Jan 20, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020

openshift-ci-robot assigned sdodson Jan 20, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

jstuever mentioned this pull request Jan 21, 2020

vshpere: download ova into cache #2922

Closed

3 tasks

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020

openshift-merge-robot merged commit b9d46c7 into openshift:master Jan 23, 2020

Add vSphere IPI destroy #2893

Add vSphere IPI destroy #2893

Uh oh!

Conversation

jcpowermac commented Jan 8, 2020

Uh oh!

jcpowermac commented Jan 8, 2020

Uh oh!

jcpowermac commented Jan 8, 2020

Uh oh!

jcpowermac commented Jan 8, 2020

Uh oh!

jcpowermac Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

jcpowermac commented Jan 16, 2020

Uh oh!

patrickdillon left a comment

Choose a reason for hiding this comment

Uh oh!

patrickdillon Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

patrickdillon Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

patrickdillon Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

patrickdillon Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Jan 20, 2020

Uh oh!

jcpowermac commented Jan 20, 2020

Uh oh!

sdodson commented Jan 20, 2020

Uh oh!

sdodson commented Jan 20, 2020

Uh oh!

openshift-ci-robot commented Jan 20, 2020

Uh oh!

openshift-bot commented Jan 21, 2020

Uh oh!

jcpowermac commented Jan 21, 2020

Uh oh!

jcpowermac commented Jan 22, 2020

Uh oh!

jcpowermac commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!

openshift-bot commented Jan 23, 2020

Uh oh!