Use PrivateDNSZones instead of DNSZones type Private for clusters#2470
Merged
openshift-merge-robot merged 5 commits intoopenshift:masterfrom Oct 8, 2019
Merged
Conversation
Contributor
Author
|
/test e2e-azure |
openshift-ci-robot
added
size/XXL
Contributor
Author
|
Missing capability for handle Private DNS Zone and its records blocks @jhixson74 Azure bring your own work as the current DNS Zone type |
abhinavdahiya
force-pushed
the
azurer_private_dns
branch
from
7d8a36f to
cc4b318
Compare
Contributor
Author
|
/test e2e-azure |
Contributor
Author
|
/retest |
abhinavdahiya
force-pushed
the
azurer_private_dns
branch
from
cc4b318 to
bf046dc
Compare
Contributor
Author
|
/test e2e-azure |
…ndle private_dns zone
Using the upstream azurerm provider is not possible for now because of following reasons:
1) There is not srv record resource for private dns zone
2) The version of provider that has the private dns zone resources `1.34.0` has a lot of bugs like
* hashicorp/terraform-provider-azurerm#4452
* hashicorp/terraform-provider-azurerm#4453
* hashicorp/terraform-provider-azurerm#4501
Some of these bugs are fixed, and some are in flight.
Another reason moving to `1.36.0` which might have all the fixes we need is the provider has moved to using
`standalone terraform plugin SDK v1.1.1` [1]. Because we vendor both terraform and providers, this causes errors like
`panic: gob: registering duplicate types for "github.com/zclconf/go-cty/cty.primitiveType": cty.primitiveType != cty.primitiveType`
Therefore, we would have to move towards a single vendor for terraform and plugins for correct inter-operation, which is tricker due to conflicts elsewhere
A simple 4 resource plugin that re-uses the already vendored azurerm provider as library and carries over the required resources seems like an easy fix for now.
[1]: hashicorp/terraform-provider-azurerm#4474
Using the Private DNS Zone also allows us to remove our previous hack [1] [1]: openshift@8ac9ab4
the ingress-operator can handle the Private DNS Zone since [1] [1]: openshift/cluster-ingress-operator#300
… deleting public records Updates the destroy to look for both DNS Zones type Private and Private DNS Zones to find the private records and the corresponding DNS Zone type Public. Since the zone name for both types of private dns zone is the same, we can try both to calculate the private records and then re-use the same codepath to delete the public records.
abhinavdahiya
force-pushed
the
azurer_private_dns
branch
from
bf046dc to
65111a0
Compare
Contributor
Author
|
/test e2e-azure |
Contributor
Author
jhixson74
approved these changes
Oct 8, 2019
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
@abhinavdahiya: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
/test e2e-aws /test e2e-azure |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terraform/exec/plugins: add embedded 'azureprivatedns' provider to handle private_dns zone
Using the upstream azurerm provider is not possible for now because of following reasons:
There is not srv record resource for private dns zone
The version of provider that has the private dns zone resources
1.34.0has a lot of bugs likeazurerm_image: add option to set the hyper_v_generation for the image hashicorp/terraform-provider-azurerm#4453Some of these bugs are fixed, and some are in flight.
Another reason moving to
1.36.0which might have all the fixes we need is the provider has moved to usingstandalone terraform plugin SDK v1.1.1azurerm-sdk-bump. Because we vendor both terraform and providers, this causes errors likepanic: gob: registering duplicate types for "github.com/zclconf/go-cty/cty.primitiveType": cty.primitiveType != cty.primitiveTypeTherefore, we would have to move towards a single vendor for terraform and plugins for correct inter-operation, which is tricker due to conflicts elsewhere
A simple 4 resource plugin that re-uses the already vendored azurerm provider as library and carries over the required resources seems like an easy fix for now.
data/azure: use azureprivatedns provider to create private records
Using the Private DNS Zone also allows us to remove our previous hack
More information in individual commits.