provider: Migrate to standalone plugin SDK v1.1.1#4474
Merged
tombuildsstuff merged 3 commits intomasterfrom Oct 7, 2019
Merged
provider: Migrate to standalone plugin SDK v1.1.1#4474tombuildsstuff merged 3 commits intomasterfrom
tombuildsstuff merged 3 commits intomasterfrom
Conversation
radeksimko
force-pushed
the
sdk-migration
branch
from
2a3b6a5 to
d9eb4be
Compare
Member
Author
|
I'm not sure what's going on with Travis - I was not able to reproduce the build failures myself locally nor in clean Docker |
Contributor
|
@radeksimko now that hashicorp/terraform-provider-azuread#154's been merged would you mind rebasing this? |
radeksimko
force-pushed
the
sdk-migration
branch
from
d9eb4be to
4404c7e
Compare
radeksimko
force-pushed
the
sdk-migration
branch
from
4404c7e to
6f5d6ce
Compare
radeksimko
changed the title
Member
Author
|
@tombuildsstuff rebased, PTAL |
tombuildsstuff
added a commit
that referenced
this pull request
Oct 7, 2019
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Oct 8, 2019
…ndle private_dns zone
Using the upstream azurerm provider is not possible for now because of following reasons:
1) There is not srv record resource for private dns zone
2) The version of provider that has the private dns zone resources `1.34.0` has a lot of bugs like
* hashicorp/terraform-provider-azurerm#4452
* hashicorp/terraform-provider-azurerm#4453
* hashicorp/terraform-provider-azurerm#4501
Some of these bugs are fixed, and some are in flight.
Another reason moving to `1.36.0` which might have all the fixes we need is the provider has moved to using
`standalone terraform plugin SDK v1.1.1` [1]. Because we vendor both terraform and providers, this causes errors like
`panic: gob: registering duplicate types for "github.com/zclconf/go-cty/cty.primitiveType": cty.primitiveType != cty.primitiveType`
Therefore, we would have to move towards a single vendor for terraform and plugins for correct inter-operation, which is tricker due to conflicts elsewhere
A simple 4 resource plugin that re-uses the already vendored azurerm provider as library and carries over the required resources seems like an easy fix for now.
[1]: hashicorp/terraform-provider-azurerm#4474
|
This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.36.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on hashicorp/terraform-provider-azuread#154I didn't run any acceptance tests for this one (yet).