data/aws/vpc/master-elb: Drop idle_timeout from aws_lb resources #2283
Conversation
It is not valid for network load balancers [1]. We've been setting this in our Terraform config since 0a96415 (modules/aws: configure ELB idle timeout, coreos/tectonic-installer#725) when we were using classic load balancers and should have dropped it in 16dfbb3 (data/aws: use nlbs instead of elbs, 2018-11-01, openshift#594). [1]: hashicorp/terraform-provider-aws@d25a227#diff-f4b0dbdc7e3eede6ba70cd286c834f37R78
openshift-ci-robot
added
size/XS
|
/hold Not worth landing this until master opens up for 4.3. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel 4.3 merge window is open |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
It is not valid for network load balancers. We've been setting this in our Terraform config since 0a96415 (coreos/tectonic-installer#725) when we were using classic load balancers and should have dropped it in 16dfbb3 (#594).
Spun off from #2279 at @abhinavdahiya's request.