This repository was archived by the owner on Feb 5, 2020. It is now read-only.
modules/aws: configure ELB idle timeout #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ok to test |
alexsomesan
approved these changes
May 17, 2017
Contributor
alexsomesan
left a comment
alexsomesan
left a comment
There was a problem hiding this comment.
LGTM.
We've discussed this offline and decided hardcoding the values. There seem to be very few situations where they would need tweaking in the context of Tectonic.
aknuds1
pushed a commit
to aknuds1/tectonic-installer
that referenced
this pull request
May 19, 2017
alekssaul
pushed a commit
to alekssaul/tectonic-installer
that referenced
this pull request
May 30, 2017
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 28, 2019
It is not valid for network load balancers [1]. We've been setting this in our Terraform config since 0a96415 (modules/aws: configure ELB idle timeout, coreos/tectonic-installer#725) when we were using classic load balancers and should have dropped it in 16dfbb3 (data/aws: use nlbs instead of elbs, 2018-11-01, openshift#594). [1]: hashicorp/terraform-provider-aws@d25a227#diff-f4b0dbdc7e3eede6ba70cd286c834f37R78
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
It is not valid for network load balancers [1]. We've been setting this in our Terraform config since 0a96415 (modules/aws: configure ELB idle timeout, coreos/tectonic-installer#725) when we were using classic load balancers and should have dropped it in 16dfbb3 (data/aws: use nlbs instead of elbs, 2018-11-01, openshift#594). [1]: hashicorp/terraform-provider-aws@d25a227#diff-f4b0dbdc7e3eede6ba70cd286c834f37R78
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390