Skip to content

update smoke test CI image #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 11, 2018
Merged

update smoke test CI image #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions images/installer-origin-release/Dockerfile
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions images/installer-origin-release/Dockerfile.ci
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# This Dockerfile is used as a CI job to build smoke tests for OpenShift installer
# FIXME: Move this image to an openshift repo?

FROM quay.io/coreos/origin-release-oc:bazel
FROM openshift/origin-release:bazel
Copy link
Member

@wking wking Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as you have it. I've been arguing for registry prefixes recently, but this is a CI-only Dockerfile (with a .ci suffix), and there I think the lack of a prefix makes more sense.

WORKDIR /go/src/github.com/openshift/installer
COPY . .

Expand Down