update smoke test CI image #228
Conversation
openshift-ci-robot
added
the
size/XS
There was a problem hiding this comment.
nit: You have two spaces in "stream is".
There was a problem hiding this comment.
Is this still accurate? Can we get it moved under quay.io/openshift?
There was a problem hiding this comment.
Is this still accurate? Can we get it moved under quay.io/openshift?
Ah, maybe this is #227.
There was a problem hiding this comment.
Don't we push to both docker.io and quay.io? If so, I think we should leave this as it was.
sallyom
force-pushed
the
fixup-installer-origin-release
branch
from
4648cba to
05ccccc
Compare
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/test e2e-aws-smoke |
|
/retest |
|
/hold @sallyom is going to update this to use openshift/ instead of coreos/ |
openshift-ci-robot
added
the
do-not-merge/hold
sallyom
force-pushed
the
fixup-installer-origin-release
branch
from
05ccccc to
cb526fe
Compare
openshift-ci-robot
added
size/S
sallyom
force-pushed
the
fixup-installer-origin-release
branch
from
cb526fe to
20b693b
Compare
| @@ -1,12 +0,0 @@ | |||
| # This Dockerfile is used to create the image quay.io/coreos/origin-release:bazel used in CI | |||
There was a problem hiding this comment.
Note to self, this Dockerfile ended up here in openshift/release#1317, so we don't need it here.
| # FIXME: Move this image to an openshift repo? | ||
|
|
||
| FROM quay.io/coreos/origin-release-oc:bazel | ||
| FROM openshift/origin-release:bazel |
There was a problem hiding this comment.
I'm fine with this as you have it. I've been arguing for registry prefixes recently, but this is a CI-only Dockerfile (with a .ci suffix), and there I think the lack of a prefix makes more sense.
|
/hold cancel |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
4 participants
@wking
we are using an initContainer in CI to copy theWe are no longer pulling from quay, but using the internally built openshift/origin-release:bazel image. We don't need to keep the Dockerfile for origin-release:bazel in this repo anymore. Please merge, thanksocbinary, so no longer have to bake that into the ci image.