Skip to content

Conversation

@stbenjam
Copy link
Member

This rhcos version has a working podman. The current pinned rhcos does
not have the backported fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1741157.

If the etcd health check fails, bootkube continues on regardless instead
of retrying. This manifests itself most catastrophically for the
baremetal IPI platform, where the first etcd health check fails very
quickly as DNS records aren't available yet.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2019
This rhcos version has a working podman.  The current pinned rhcos does
not have the backported fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1741157.

If the etcd health check fails, bootkube continues on regardless instead
of retrying. This manifests itself most catastrophically for the
baremetal IPI platform, where the first etcd health check fails very
quickly as DNS records aren't available yet.
@hardys
Copy link

hardys commented Aug 28, 2019

/test e2e-aws-upgrade

@russellb
Copy link
Contributor

/retest

@yuqi-zhang
Copy link
Contributor

/test e2e-azure

Just to be safe

@yuqi-zhang
Copy link
Contributor

/test e2e-aws

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Azure failure is not OS related so I think this update is safe to go

@abhinavdahiya
Copy link
Contributor

/lgtm

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, stbenjam, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019
@stbenjam
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit d7621ca into openshift:master Aug 28, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 28, 2019

@stbenjam: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-azure 293a854 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam stbenjam deleted the rhcos-podman branch August 28, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants