Skip to content

Conversation

@bcrochet
Copy link
Member

@bcrochet bcrochet commented Aug 8, 2019

The baremetal bootstrap assets have moved into machine-config-operator.
These files are vestigal and are no longer required. They can be safely
removed.

The baremetal bootstrap assets have moved into machine-config-operator.
These files are vestigal and are no longer required. They can be safely
removed.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2019
@bcrochet
Copy link
Member Author

bcrochet commented Aug 8, 2019

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Aug 8, 2019
@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2019
@metal3ci
Copy link

metal3ci commented Aug 8, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1016/

@bcrochet
Copy link
Member Author

/test e2e-aws-scaleup-rhel7

@abhinavdahiya
Copy link
Contributor

/hold

The master is open only for bug fixes as we prepare for 4.2 release. this need a bugzilla targeted for 4.2 to merge.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2019
@bcrochet
Copy link
Member Author

/retest

@hardys
Copy link

hardys commented Aug 28, 2019

@bcrochet: what's the plan for this - I guess these now-redundant assets can be considered a bug, so you can raise a bz against 4.2 then update the title of this PR so we can remove the hold?

@hardys
Copy link

hardys commented Aug 28, 2019

Also would be good to see metal3ci pass, but that's currently blocked on #2277

@bcrochet
Copy link
Member Author

@bcrochet: what's the plan for this - I guess these now-redundant assets can be considered a bug, so you can raise a bz against 4.2 then update the title of this PR so we can remove the hold?

@hardys: We can, but I don't think it's necessary for 4.2. These are on the bootstrap node, which makes them ephemeral anyway.

But if you feel strongly that it should go into 4.2, I'll create the bz. I had planned for this to just land once 4.3 opened up.

@hardys
Copy link

hardys commented Aug 28, 2019

@hardys: We can, but I don't think it's necessary for 4.2. These are on the bootstrap node, which makes them ephemeral anyway.

Ok thanks for confirming, that's fine by me, just wanted to ensure this wasn't blocked on a bz unintentionally :)

@abhinavdahiya
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
@abhinavdahiya
Copy link
Contributor

/assign @bcrochet @russellb

@bcrochet
Copy link
Member Author

/retest

@stbenjam
Copy link
Member

stbenjam commented Sep 26, 2019

@patrickdillon
Copy link
Contributor

/uncc @patrickdillon
will leave this to more knowledgeable folks

@openshift-ci-robot openshift-ci-robot removed the request for review from patrickdillon September 26, 2019 20:44
@stbenjam
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, bcrochet, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6ab100a into openshift:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants