-
Notifications
You must be signed in to change notification settings - Fork 1.5k
baremetal: Remove unused assets #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baremetal: Remove unused assets #2182
Conversation
The baremetal bootstrap assets have moved into machine-config-operator. These files are vestigal and are no longer required. They can be safely removed.
|
/label platform/baremetal |
|
/approve |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1016/ |
|
/test e2e-aws-scaleup-rhel7 |
|
/hold The master is open only for bug fixes as we prepare for 4.2 release. this need a bugzilla targeted for 4.2 to merge. |
|
/retest |
|
@bcrochet: what's the plan for this - I guess these now-redundant assets can be considered a bug, so you can raise a bz against 4.2 then update the title of this PR so we can remove the hold? |
|
Also would be good to see metal3ci pass, but that's currently blocked on #2277 |
@hardys: We can, but I don't think it's necessary for 4.2. These are on the bootstrap node, which makes them ephemeral anyway. But if you feel strongly that it should go into 4.2, I'll create the bz. I had planned for this to just land once 4.3 opened up. |
Ok thanks for confirming, that's fine by me, just wanted to ensure this wasn't blocked on a bz unintentionally :) |
|
/hold cancel |
|
/retest |
|
/uncc @patrickdillon |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, bcrochet, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The baremetal bootstrap assets have moved into machine-config-operator.
These files are vestigal and are no longer required. They can be safely
removed.