-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Revert "RHCOS: update to release 42.80.20190823.0" #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 067c05a. This version of RHCOS is shipping with a broken podman that does not correctly return exit codes. The fix from https://bugzilla.redhat.com/show_bug.cgi?id=1741157 needs to be backported into a new podman RPM for EL8 and the fix brought into RHCOS. If the etcd health check fails, bootkube continues on regardless instead of retrying. This manifests itself most catastrophically for the baremetal IPI platform, where the first etcd health check fails very quickly as DNS records aren't available yet.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hmm but that's going to back out other important fixes... |
|
We could also ask for a new RHCOS build with an older podman without this problem |
|
baremetal IPI is most obviously hit by this, but having a broken podman like this is pretty catastrophic and is probably going to manifest itself in other odd ways. We should get a newer podman soon, but it would be a few days, and it's a long time to be in this situation. |
|
Older |
|
I'm more inclined towards not backing out important fixes for our GA platforms like Azure, vSphere. |
|
We may get a new RHCOS relatively quickly, backport PR is open containers/podman#3895 |
|
We're working on both getting the new one, as well as a build for reverting ONLY podman to the old version for RHCOS. I think this can be closed in favour of either one. |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Sounds good to me, thanks so much /close |
|
@stbenjam: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit 067c05a. This
version of RHCOS is shipping with a broken podman that does not
correctly return exit codes. The fix from
https://bugzilla.redhat.com/show_bug.cgi?id=1741157 needs to be
backported into a new podman RPM for EL8 and the fix brought into RHCOS.
If the etcd health check fails, bootkube continues on regardless instead
of retrying. This manifests itself most catastrophically for the
baremetal IPI platform, where the first etcd health check fails very
quickly as DNS records aren't available yet.