Skip to content

RHCOS: update to release 42.80.20190823.0 #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 26, 2019
Merged

RHCOS: update to release 42.80.20190823.0 #2264

openshift-merge-robot merged 1 commit into from
Aug 26, 2019

Conversation

@yuqi-zhang
Copy link
Contributor

@yuqi-zhang yuqi-zhang commented Aug 23, 2019

This update pulls in:

  • an early Azure checkin module, which shortens OS boot time from
    ~7min to ~2min30s in terraform
  • bare metal ip persist via the coreos-installer

(Note: this is intended as 4.2 bugfixing)

@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Aug 23, 2019

/test e2e-azure

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 23, 2019
@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Aug 23, 2019

cc @ashcrow @abhinavdahiya @crawford

@yuqi-zhang
RHCOS: update to release 42.80.20190823.0
067c05a 
This update pulls in:
 - an early Azure checkin module, which shortens OS boot time from
   ~7min to ~2min30s in terraform
 - bare metal ip persist via the coreos-installer

Signed-off-by: Yu Qi Zhang <[email protected]>
@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Aug 23, 2019

/test e2e-azure

@ashcrow
Copy link
Member

ashcrow commented Aug 23, 2019

Makes sense to me 👍

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 23, 2019

/test e2e-gcp

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 23, 2019

/test e2e-azure

1 similar comment
@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Aug 23, 2019

/test e2e-azure

@jcpowermac
Copy link
Contributor

jcpowermac commented Aug 23, 2019 •
edited
Loading

Need this update for vsphere:
https://bugzilla.redhat.com/show_bug.cgi?id=1736875

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 23, 2019 •
edited
Loading

/approve

The openstack-e2e failure is concerning.

/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 23, 2019

/retest

@iamemilio
Copy link

iamemilio commented Aug 23, 2019

/test e2e-openstack

@stbenjam stbenjam mentioned this pull request Aug 23, 2019
Merged
@mandre
Copy link
Member

mandre commented Aug 24, 2019

/test e2e-openstack

@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Aug 26, 2019

All the CI runs seem to have passed. Should we give this the 👍 or run openstack a few more times to be sure?

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ashcrow, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow
Copy link
Member

ashcrow commented Aug 26, 2019

/retest

@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Aug 26, 2019 

go build -ldflags ' -X github.com/openshift/installer/pk...' release' -o bin/openshift-install ./cmd/openshift-install
go build github.com/openshift/installer/vendor/github.com/...r/local/go/pkg/tool/linux_amd64/compile: signal: terminated
error: build error: running 'hack/build.sh' failed with exit code 1

I didn't change how the image is built at all so did that break somewhere else? That shouldn't be a flake AFAIK

@ashcrow
Copy link
Member

ashcrow commented Aug 26, 2019 

+ go build -ldflags ' -X github.com/openshift/installer/pk...' release' -o bin/openshift-install ./cmd/openshift-install
go build github.com/openshift/installer/vendor/github.com/...r/local/go/pkg/tool/linux_amd64/compile: signal: terminated

😕

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@yuqi-zhang
Copy link
Contributor Author

yuqi-zhang commented Aug 26, 2019

FWIW the build works fine locally cc @abhinavdahiya

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0a98dbe into openshift:master Aug 26, 2019
@wking
Copy link
Member

wking commented Aug 27, 2019

#2274 is considering backing this out, because the RHCOS bump pulled in a broken podman. Folks who were on this PR may be interested in hashing out pros/cons to the revert on the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow ashcrow approved these changes

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@yuqi-zhang @ashcrow @abhinavdahiya @jcpowermac @iamemilio @mandre @openshift-ci-robot @openshift-bot @wking @openshift-merge-robot