Skip to content

Bug 1741930: allow to define OpenStack image name #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fedosin wants to merge 1 commit into from
Closed

Bug 1741930: allow to define OpenStack image name #2226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/asset/rhcos/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func osImage(config *types.InstallConfig) (string, error) {
case libvirt.Name:
osimage, err = rhcos.QEMU(ctx)
case openstack.Name:
osimage = "rhcos"
osimage = config.Platform.OpenStack.BaseImage
case azure.Name:
osimage, err = rhcos.VHD(ctx)
case baremetal.Name:
Expand Down
4 changes: 4 additions & 0 deletions pkg/types/openstack/defaults/platform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ func SetPlatformDefaults(p *openstack.Platform) {
p.Cloud = DefaultCloudName
}
}

if p.BaseImage == "" {
p.BaseImage = "rhcos"
}
}

// APIVIP returns the internal virtual IP address (VIP) put in front
Expand Down
4 changes: 4 additions & 0 deletions pkg/types/openstack/platform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ type Platform struct {
// Existing Floating IP to associate with the OpenStack load balancer.
LbFloatingIP string `json:"lbFloatingIP"`

// BaseImage
// Name of the Red Hat CoreOS image in Glance.
BaseImage string `json:"baseImage"`

// TrunkSupport
// Whether OpenStack ports can be trunked
TrunkSupport string `json:"trunkSupport"`
Expand Down