Skip to content

Bug 1741930: allow to define OpenStack image name #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Fedosin wants to merge 1 commit into from
Closed

Bug 1741930: allow to define OpenStack image name #2226

Fedosin wants to merge 1 commit into from

Conversation

@Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Aug 16, 2019

This commit adds a new option to the install config: BaseImage, that allows to set a custom RHCOS image name in Glance.
By default it is still "rhcos".

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1741930

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 16, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 16, 2019

@Fedosin: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.2.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1741930: allow to define OpenStack image name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 16, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 16, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 16, 2019

@Fedosin: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 16, 2019
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 16, 2019

@Fedosin We cannot merge any changes to install-config.yaml as we are in feature freeze for 4.2

abhinavdahiya
abhinavdahiya reviewed Aug 16, 2019
View reviewed changes
pkg/tfvars/openstack/openstack.go Outdated
Copy link
Contributor

@abhinavdahiya abhinavdahiya Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image name should come through the Master Machine object.

Copy link
Contributor Author

@Fedosin Fedosin Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2019
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 16, 2019

@abhinavdahiya How would you recommend fixing this bug at 4.2? Generally speaking I can define an env variable for that, but we already have OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE
Is there any other place where we can set a custom image name?

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 16, 2019

The bug is unpleasant, so it will be awesome if we can fix it in 4.2

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 16, 2019

/test e2e-openstack

@Fedosin
Bug 1741930: allow to define openstack image name
848c814 
This commit adds a new option to the install config: baseImage, that
allows to set a custom RHCOS image name in Glance.
By default it is still "rhcos".
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2019
@mandre mandre mentioned this pull request Aug 18, 2019
Merged
@mandre
Copy link
Member

mandre commented Aug 18, 2019

/hold

We need to clarify the release target in https://bugzilla.redhat.com/show_bug.cgi?id=1741930.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2019
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 19, 2019

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Aug 19, 2019

/label platform/openstack

@Fedosin Fedosin closed this Aug 20, 2019
@Fedosin Fedosin deleted the set_image_name branch November 1, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. platform/openstack size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fedosin @openshift-ci-robot @abhinavdahiya @mandre