Bug 1741637: openstack: Add API Floating IP survey question

[tomassedovic]

Without a floating IP address, the cluster will not be accessible from
the outside, which means the installer will fail when it tries to
communicate with the OpenShift API.

This adds the necessary prompt that lists all floating IPs that are
available on the previously selected external network.

[tomassedovic]

/label platform/openstack

[tomassedovic]

This is best tested in conjunction with #2036

But it can be merged independently.

[tomassedovic]

I need to fix the tests, I did get an install complete locally with entering all the values via prompts rather than writing an install config.

[tomassedovic]

/retest

[iamemilio]

/retest

[tomassedovic]

/retest

[tomassedovic]

/test e2e-aws-scaleup-rhel7

[mandre]

/test e2e-openstack

[abhinavdahiya]

/hold

The master is open only for bug fixes as we prepare for 4.2 release. this need a bugzilla targeted for 4.2 to merge.

[iamemilio]

@abhinavdahiya https://bugzilla.redhat.com/show_bug.cgi?id=1741637

[openshift-ci-robot]

@tomassedovic: This pull request references an invalid Bugzilla bug:

• expected the bug to target the "4.2.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1741637: openstack: Add API Floating IP survey question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhinavdahiya]

/hold cancel

[iamemilio]

/bugzilla refresh

[openshift-ci-robot]

@iamemilio: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamemilio]

Thanks @abhinavdahiya :)

[iamemilio]

Please update your review request @abhinavdahiya

[mandre]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, mandre, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/openstack/OWNERS [abhinavdahiya,mandre,tomassedovic]
• pkg/types/openstack/OWNERS [abhinavdahiya,mandre,tomassedovic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@tomassedovic: All pull requests linked via external trackers have merged. Bugzilla bug 1741637 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1741637: openstack: Add API Floating IP survey question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.