Skip to content

Conversation

@tomassedovic
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2019
@tomassedovic tomassedovic changed the title Add OpenStack to the installation wizard openstack: Add OpenStack to the platform selection Jul 18, 2019
@tomassedovic
Copy link
Contributor Author

/label platform/openstack

@tomassedovic
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor

Are there doc updates that would help with this change?

@eparis
Copy link
Member

eparis commented Jul 29, 2019

/retest

@tomassedovic
Copy link
Contributor Author

@abhinavdahiya sorry, yes. We've been focusing on the service VM removal and I've mostly opened this so we don't forget to do it.

I plan to address these PRs and then bring our docs up to date:

#1959
openshift/machine-config-operator#740

@tomassedovic
Copy link
Contributor Author

/test e2e-openstack

1 similar comment
@tomassedovic
Copy link
Contributor Author

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Aug 9, 2019

/retest

1 similar comment
@tomassedovic
Copy link
Contributor Author

/retest

@tomassedovic
Copy link
Contributor Author

tomassedovic commented Aug 9, 2019

@abhinavdahiya all the pull requests we needed to merge are now in.

The docs are open but ready to go: #2148.

Would you mind taking another look at this please? I'm not sure whether this is required for the FFE or if it can be merged later.

@abhinavdahiya
Copy link
Contributor

/lgtm

cc @crawford @cuppett

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cuppett
Copy link
Member

cuppett commented Aug 9, 2019

/test e2e-aws-scaleup-rhel7

@openshift-merge-robot openshift-merge-robot merged commit d4ca8c2 into openshift:master Aug 9, 2019
@openshift-ci-robot
Copy link
Contributor

@tomassedovic: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 0bf9ccd link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants