Skip to content

pkg/types/installconfig: Drop DNSServer #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 6, 2018
Merged

pkg/types/installconfig: Drop DNSServer #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Documentation/design/installconfig.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ type LibvirtNetwork struct {
Name string `json:"name"`
// IfName is the name of the network interface.
IfName string `json:"if"`
// DNSServer is the name of the DNS server.
DNSServer string `json:"resolver"`
// IPRange is the range of IPs to use.
IPRange string `json:"ipRange"`
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/asset/installconfig/installconfig_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ func TestInstallConfigGenerate(t *testing.T) {
network:
if: ""
ipRange: ""
name: ""
resolver: ""`,
name: ""`,
},
}
for _, tc := range cases {
Expand Down
2 changes: 0 additions & 2 deletions pkg/types/installconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ type LibvirtNetwork struct {
Name string `json:"name"`
// IfName is the name of the network interface.
IfName string `json:"if"`
// DNSServer is the name of the DNS server.
DNSServer string `json:"resolver"`
// IPRange is the range of IPs to use.
IPRange string `json:"ipRange"`
}