Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Sep 6, 2018

Catching up with 13a7dbb (#214).

CC @abhinavdahiya, @crawford, @eparis

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2018
@eparis
Copy link
Member

eparis commented Sep 6, 2018

/lgtm
guess I missed some. thx

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
Catching up with 13a7dbb (Remove the 'dns' options from libvirt,
2018-08-26, openshift#214).
@wking wking force-pushed the install-config-drop-dns-server branch from 7f6444d to 285f7b5 Compare September 6, 2018 17:01
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
@eparis
Copy link
Member

eparis commented Sep 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 44bedfe into openshift:master Sep 6, 2018
@wking wking deleted the install-config-drop-dns-server branch September 6, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants